WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 2 months ago

#53922 closed defect (bug) (fixed)

Docblock in get_block_editor_settings function

Reported by: tmatsuur's profile tmatsuur Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.8.1 Priority: normal
Severity: normal Version: 5.8
Component: Editor Keywords: has-patch fixed-major
Focuses: docs Cc:

Description

The docblock of the get_block_editor_settings function has two "settings" in a row, as shown below.

Returns the contextualized block editor settings settings for a selected editor context.

Isn't this a typo?

Change History (6)

#1 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 5.8.1

Good catch! Introduced in [50776] / #52920.

This ticket was mentioned in ​PR #1583 on ​WordPress/wordpress-develop by ​pbearne.
3 years ago #2

  • Keywords has-patch added

Removed extra "setting" in doc block

Trac ticket: https://core.trac.wordpress.org/ticket/53922

#3 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 51611:

Docs: Fix typo in the get_block_editor_settings() description.

Follow-up to [50776].

Props tmatsuur, pbearne.
Fixes #53922.

#4 @SergeyBiryukov
3 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 5.8.1 consideration.

#5 @desrosj
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 51621:

Docs: Fix typo in the get_block_editor_settings() description.

Follow-up to [50776].

Props tmatsuur, pbearne, SergeyBiryukov.
Merges [51611] to the 5.8 branch.
Fixes #53922.

​@SergeyBiryukov commented on ​PR #1583:
2 months ago #6

Thanks for the PR! Merged in r51611.

Note: See TracTickets for help on using tickets.