WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #53945, comment 29


Ignore:
Timestamp:
09/02/2021 03:19:48 AM (3 years ago)
Author:
hellofromTonya
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #53945, comment 29

    initial v1  
    1313the subtle difference of `run phpunit phpunit` vs `run phpunit php ./vendor/bin/phpunit`.
    1414
    15 Running `npm run test:php` on one of my machines that doesn't have PHPUnit phar installed nor PHPUnit installed via composer globally, it works. The only instance of PHPUnit is in the vendor bin.
     15~~Running `npm run test:php` on one of my machines that doesn't have PHPUnit phar installed nor PHPUnit installed via composer globally, it works. The only instance of PHPUnit is in the vendor bin.~~
    1616
    17 Why does it work? Hmm, I'll do more investigation and testing to discover why.
     17~~Why does it work? Hmm, I'll do more investigation and testing to discover why.~~
     18
     19**Update**:
     20
     21Okay I see. The phar is installed in the Docker container and that's used when running `npm run test:php`. I mistakingly thought this phar file wasn't installed in the container but instead only Composer version was used. My mistake.
     22
     23So yes, [https://github.com/WordPress/wordpress-develop/pull/1647 PR 1647] is invalid.
     24
     25Also, we'll need to update the handbook and README.md for when to use `test:php` vs. `test:php-composer`.