exif_read_data() called for non-jpeg/tiff image files, resulting in error

[fitztrev]

​exif_read_data(), added in #5162, only accepts JPEG and TIFF files but is being called for GIF and PNG as well.

When uploading a GIF file (ex: the Google logo) via the Write Post upload form, I'm getting the following error message:

Warning: exif_read_data(logo.gif) [function.exif-read-data]: File not supported in /var/www/trunk/wp-admin/includes/image.php on line 291

Confirmed with a .bmp on PHP5.2.4 + Apache/win32

Given that the filetypes that the exif functions accept might change between installs/versions (i'm honestly not sure), I think the best method might to suppress the errors, That works fine here and allows the upload to go ahead as usual.

Suppressing errors is never sexy.

If I was going to make a patch, I would explicitly check for either GIF and TIFF and run that through a filter.

However, since I'm not going to make a patch to counter yours, then I think yours is sexy... enough.

I agree that error suppressing is never sexy, So i'll attach another patch without it.

Your first patch covered two areas or functions. Your second, while sexier, only covers one of the areas/functions. Is this intentional?

Line 273 - iptcparse() (not covered)
Line 291 - exif_read_data() (covered)

Yep, Its intentional, The first function(iptcparse()) is not called unless there is data for it to parse( $infoAPP13? from getimagesize() ).

That is one fine patch then.

(In [6438]) Ensure we don't call exif_read_data() on unsupported file types. Fixes #5397 props DD32