WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#53971 closed enhancement (fixed)

test for wp_is_numeric_array()

Reported by: pbearne's profile pbearne Owned by: hellofromtonya's profile hellofromTonya
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch has-unit-tests commit
Focuses: Cc:

Description


Change History (7)

This ticket was mentioned in ​PR #1610 on ​WordPress/wordpress-develop by ​pbearne.
3 years ago #1

  • Keywords has-patch has-unit-tests added

Trac ticket: https://core.trac.wordpress.org/ticket/53971

#2 @Hareesh Pillai
3 years ago

Thanks for the patch, @pbearne.
While testing it, I noticed that the patch includes a change in the composer.json file. Is that expected?

#3 @pbearne
3 years ago

no, the compose.json is an error will fix :-(

#4 @hellofromTonya
3 years ago

  • Keywords commit added
  • Owner set to hellofromTonya
  • Status changed from new to reviewing

#5 @hellofromTonya
3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 52037:

General: Add phpunit tests for wp_is_numeric_array().

Adds new test class Tests_Functions_WpIsNumericArray for wp_is_numeric_array().

Props pbearne, hareesh-pillai, hellofromTonya.
Fixes #53971.

#7 @SergeyBiryukov
3 years ago

In 52048:

Tests: Remove the formatting group from wp_is_numeric_array() tests.

Similar to wp_array_slice_assoc() or other array-related functions, this appears to be a general-purpose function unrelated to the Formatting component.

Add missing public visibility keyword.

Follow-up to [52037].

See #53971.

Note: See TracTickets for help on using tickets.