Opened 3 years ago
Closed 3 years ago
#53980 closed enhancement (fixed)
Upgrade Site Health “Great job!” Checkmark (Dashicon)
Reported by: | jetxpert | Owned by: | Clorith |
---|---|---|---|
Milestone: | 5.9 | Priority: | normal |
Severity: | normal | Version: | 5.8 |
Component: | Site Health | Keywords: | has-patch |
Focuses: | administration | Cc: |
Description
Good Day!
It would be awesome if you guys can upgrade subject dashicon to a more modern, better looking version as requested below.
Thank you!
Attachments (3)
Change History (17)
#2
@
3 years ago
- Focuses administration added
- Milestone Awaiting Review deleted
- Resolution set to wontfix
- Status changed from new to closed
#4
follow-up:
↓ 8
@
3 years ago
- Milestone set to Awaiting Review
- Resolution wontfix deleted
- Status changed from closed to reopened
Apologies! It seems I misunderstood the suggestion originally. My understanding was that this was a request to add a new icon to the Dashicons font (which would not be considered).
The issue created over on GitHub suggests switching to using a different icon that already exists within the font. Switching an icon used within Core code can be considered. That is a discussion relevant to Trac, so reopening this.
Sorry for the goose chase.
#5
@
3 years ago
@desrosj,
You did not misunderstand the original suggestion. We learned from you, so we made an adjustment.
Just updated GitHub Issue No. 432 to suggest using the dashicon: dashicons-heart
Looks great in the backend and suits better the term "Site Health."
Hopefully, Team WordPress will approve and make the change.
Cheers!
#6
@
3 years ago
- Keywords has-patch added
The heart icon fits well here (or perhaps the smiley).
I made a patch to include aria-hidden
with the heart icon. Instead of adding a 20px bottom margin, the height is increased to 150px so that matches the font size and width.
#7
@
3 years ago
@sabernhardt,
Tested your patch at our end. Everything looks great.
Good to go. Thank you!
#8
in reply to:
↑ 4
@
3 years ago
Replying to desrosj:
Apologies! It seems I misunderstood the suggestion originally. My understanding was that this was a request to add a new icon to the Dashicons font (which would not be considered).
The issue created over on GitHub suggests switching to using a different icon that already exists within the font. Switching an icon used within Core code can be considered. That is a discussion relevant to Trac, so reopening this.
Sorry for the goose chase.
Hi @desrosj! Stumbled upon this ticket. Any chance this suggestion can be tabled for WP Milestone 5.9? Thank you.
This ticket was mentioned in Slack in #core-site-health by sabernhardt. View the logs.
3 years ago
#10
follow-up:
↓ 11
@
3 years ago
I'm happy to explore different icons to use here, but we need to keep in mind that this needs to be internationally considered "good".
A black heart may be associated with a negative feeling, or in some cases irony, and may not be the best option here.
I can for reference include that the initial icon was the thumbs up dashicon, but this was also dropped because that is a very rude gesture in some parts of the world.
#11
in reply to:
↑ 10
@
3 years ago
Replying to Clorith:
I'm happy to explore different icons to use here, but we need to keep in mind that this needs to be internationally considered "good".
A black heart may be associated with a negative feeling, or in some cases irony, and may not be the best option here.
I can for reference include that the initial icon was the thumbs up dashicon, but this was also dropped because that is a very rude gesture in some parts of the world.
Hi @Clorith!
Excellent feedback.
We reviewed WP's approved list of dashicons. It appears your concern can be solved by using WP's smiley dashicon (dashicons-smiley) https://developer.wordpress.org/resource/dashicons/#smiley.
Would be a nice change to WP's current Site Health dashicon.
#12
@
3 years ago
@sabernhardt,
Given the geometry of the smiley dashicon, the following CSS code should make things look a tad better:
margin-bottom: .5rem;
Can you double-check me on that? Thoughts appreciated.
Thank you.
#13
@
3 years ago
- Milestone changed from Awaiting Review to 5.9
- Owner set to Clorith
- Status changed from reopened to assigned
I like how this looks, the happy little friend there, I'll make some minor adjustments to the margins to make it looks a bit more natural, both on desktop and mobile, but other than that, yeah we'll get this included.
Hi @jetxpert,
Thanks for this!
The Dashicons font is no longer accepting requests to add new icons or adjust preexisting ones.
A full breakdown can be found in the blog post. If this changes, this request would need to be submitted on the GitHub repository.