Change suggested maximum image size to 2560 pixel (like big image threshold)

[zodiac1978]

In #47872 we introduced and in #49280 we refined the error message for a broken image upload to this text:

Post-processing of the image failed likely because the server is busy or does not have enough resources. Uploading a smaller image may help. Suggested maximum size is 2500 pixels.

But in #47873 the big image threshold is set to 2560 pixel which is not 2500 pixel but not much away.

I think this could be confusing for beginners. Which is the recommended maximum size? 2560 or 2500 pixels?

Would it make sense to change the last sentence to "Suggested maximum size is 2560 pixels."?

[zodiac1978]

Duplicate of #53984.

[zodiac1978]

Closed the wrong ticket :(

Created this ticket twice due to a internal server error on submission.

[zodiac1978]

#53984 was marked as a duplicate.

[zodiac1978]

Change suggested maximum size to 2560 pixel instead of 2500 pixel

[mukesh27]

Agreed with @zodiac1978. We have to use 2560 pixels instead of 2500 pixels so others don't get confuse.

Let's wait for core dev feedback then will make it commit

[SergeyBiryukov]

My initial though was that 2500 might have been chosen as a reasonable, easy-to-remember value below the default big_image_size_threshold filter value (2560), to avoid using additional resources for post-processing.

I was wondering what would happen if the image is exactly 2560 pixels on either side. Looking at [46076] / #47873, scaling the image down to use as the "full" size only happens if it's larger than the threshold value, so suggesting 2560 for consistency should still be fine.

[antpb]

this came up in the recent Media component meeting. I agree, changing the message to be exactly the value is the right call.

@joyously mentioned that because the value is able to be filtered maybe we should directly use that filterable value in the place where this message mentions the size.

[zodiac1978]

Replying to antpb:

@joyously mentioned that because the value is able to be filtered maybe we should directly use that filterable value in the place where this message mentions the size.

Good thought! On the other hand is the error message a warning about an image that is maybe too big to handle for the server. Using the filtered value could give the wrong expression that the filtered value is something WordPress itself is recommending.

If someone uses the filter they should be aware of the implications, but we all know that copying & pasting code snippets happens a lot ...

[webcommsat]

1) Agree having the actual maximum size of an image will be clearer for users.

2) We may need to check if there are any LearnWP resources which refer to 2500 pixels that would need to be changed to 2560 too. Will check with the Training team once this ticket goes through.

3) Suggest a reword of the text to make it easier to follow especially for new users. As we are approaching feature freeze, this reword has been re-reviewed with @marybaum.
Change from:
"Post-processing of the image failed likely because the server is busy or does not have enough resources. Uploading a smaller image may help. Suggested maximum size is 2560 pixels."
to:
"The server can not process the image. This can happen if the server is busy or does not have enough resources to complete the task. Uploading a smaller image may help. Suggested maximum size is 2560 pixels."

[hellofromTonya]

As this ticket is improving the wording/copy, it can go past Feature Feature.

[adamsilverstein]

The updated wording in https://core.trac.wordpress.org/ticket/53985#comment:14 looks good to me!

[hellofromTonya]

Rewords per copy review (see comment 14)

[hellofromTonya]

Marking for commit and has-copy-review.

[adamsilverstein]

Looks good @hellofromTonya - I will commit this.

Trac ticket:

[adamsilverstein]

Fixed in r52189 where I left off the "#" hence this ticket not getting auto-closed.