Lets add WP_User object to "registration_redirect" filter

[Collizo4sky]

I am the maintainer of Peters login redirect plugin. One of the most request feature is to redirect users after registration based on certain user characteristics.

Please, I want

$redirect_to = apply_filters( 'registration_redirect', $registration_redirect );

To change to

$redirect_to = apply_filters( 'registration_redirect', $registration_redirect, $errors );

[mukesh27]

Hi there!

If we add new argument then we also need to add document for it. Also i think we have to change that $errors variable with proper name so other don't get confuse.

[Collizo4sky]

@mukesh27 totally agreed. Currently away from my computer.

If you can submit a patch, that would be great.

[aadilali]

I have crated the patch for this.

[aadilali]

Hi,

Patch has been added but it need testing.

[mukesh27]

@aadilali thanks for the patch.

I think we have to add a @since note for the new filter parameter

[aadilali]

Replying to mukesh27:

@aadilali thanks for the patch.

I think we have to add a @since note new filter parameter

Should I add @since note and update the patch?

[aadilali]

Patch with @since note

[hellofromTonya]

This patch is not changing redirection functionality. Rather, it's passing the errors to hooked callbacks. In today's test scrub, it was determined that manual testing is not needed. Why? apply_filters() is well tested and the passing of another variable/data item is known to work.

Trac ticket: https://core.trac.wordpress.org/ticket/53992

[audrasjb]

Patch refreshed in the PR above. Tests are passing well.
Marking for commit.

[davidbaumwald]

In 52091:

Login and Registration: Pass $errors parameter to registration_redirect filter.

On user registration, the $errors variable is the result of register_new_user which contains either the newly registered user's ID on success or a WP_Error object on failure. This change passes that context to the registration_redirect filter.

Props Collizo4sky, aadilali, mukesh27, audrasjb.
Fixes #53992.

Committed to core via changeset https://core.trac.wordpress.org/changeset/52091