Bump Akismet (5.9 Edition)

[kraftbj]

See #53555, #52245, #51610, #50032, #49662, #47269, #46211, #43371, #41327, #40002, etc.

The next version of Akismet has been released so need build.svn to bump the external.

akismet http://plugins.svn.wordpress.org/akismet/tags/4.1.11/

[kraftbj]

4.1.12 is out:

akismet http://plugins.svn.wordpress.org/akismet/tags/4.1.12/

[dd32]

trunk: ​[build51339]
branches/5.8: ​[build51340]

[kraftbj]

4.2.1 is out:

akismet http://plugins.svn.wordpress.org/akismet/tags/4.2.1/

[desrosj]

@dd32 Can this be bumped prior to 5.8.2 next week?

[dd32]

Thanks for the ping @desrosj

Trunk: ​[build51597]
5.8: ​[build51598]

[dd32]

Thanks to @chadworthman ​manually bumping akismet is no longer required.

The svn:external for the latest branch, and trunk, will be updated automatically with every commit.

For example, ​[build51608] would've bumped the version if a new version of Akismet was releaed.

I'm marking this as fixed, with a request that @kraftbj (or someone else) checks that ​https://build.trac.wordpress.org/browser/trunk/wp-content/plugins links to the latest version of Akismet after the next core commit following an akismet release.

[kraftbj]

@dd32 and @chadworthman — This is great news and a welcome enhancement.

I'll confirm the next release is bumped on build. Generally, I pretty regularly use a site set to track trunk and will notify when Akismet has an update. I'll be sure to verify and report if anything ever seems to be broken.

[desrosj]

Looks like a new release dropped today (4.2.2). @dd32 would it be possible for you update this prior to 5.9 on Tuesday.

[SergeyBiryukov]

Replying to dd32:

I'm marking this as fixed, with a request that @kraftbj (or someone else) checks that ​https://build.trac.wordpress.org/browser/trunk/wp-content/plugins links to the latest version of Akismet after the next core commit following an akismet release.

In addition to trunk, does it also need to be bumped in the 5.9 branch? Still points to 4.2.1 at the moment:
​https://build.trac.wordpress.org/browser/branches/5.9/wp-content/plugins

The RC4 commit was ~20 minutes after the Akismet 4.2.2 release:
​https://plugins.trac.wordpress.org/changeset/2663649/akismet
​https://build.trac.wordpress.org/changeset/52223

[kraftbj]

I'm sorry about this y'all—I didn't realize this was on deck to ship until it did.

[peterwilsoncc]

Replying to SergeyBiryukov:

In addition to trunk, does it also need to be bumped in the 5.9 branch? Still points to 4.2.1 at the moment:
​https://build.trac.wordpress.org/browser/branches/5.9/wp-content/plugins

I think it needs to be bumped in the 5.9 branch to avoid immediate upgrade notifications on a fresh WP installation.

[dd32]

Hmm... The automatic bumping worked kind-of!

Trunk was automatically updated in ​https://build.trac.wordpress.org/changeset/52225/trunk/wp-content/plugins

branches/5.8 will be automatically updated next-time there's a commit to it.

branches/5.9 didn't get automatically bumped, as the script bumps trunk & the branch of the version that ​https://api.wordpress.org/core/version-check/1.7/ returns.

We didn't think about the notion of core being branched before release and there being an Akismet update in that time.

I'll manually bump it for 5.9, and get the automatic bumping fixed up.
The current code is:

svn propset svn:externals "akismet $LATEST_AKISMET_VERSION/" $CORE_CO/trunk/wp-content/plugins
svn propset svn:externals "akismet $LATEST_AKISMET_VERSION/" $CORE_CO/branches/$LATEST_CORE_BRANCH/wp-content/plugins

I think I'll have to create a new API for it, and return [ trunk, WP_CORE_DEV_BRANCH (5.9), WP_CORE_STABLE_BRANCH (5.8) ] for this scenario, and [ trunk, WP_CORE_STABLE_BRANCH (5.9) ] for normal.. or just make $LATEST_CORE_BRANCH reflect the dev-branch instead of stable-branch after release branching..

Bumped it for branches/5.9 in ​https://build.trac.wordpress.org/changeset/52227

[dd32]

Marking as closed, it was bumped for 5.9, and I've followed up with systems to get the auto-bumping bumping in this edge-case: ​https://make.wordpress.org/systems/?p=1717#comment-1973