Wp Multisite Get, Add, Update and Delete Site Meta Issue.

[leeml]

Just working on some code to help with WP Multisite integration...

I have noticed that the add_site_meta function is currently not working.

I had a look through the functions in wp-includes/ms-site.php and found that the first parameter in the 'add_metadata' function called by add_site_meta (line 1012) is 'blog'.

I figured since you changed the blogmeta table to sitemeta that something might be amiss. If the metadata is added thus:

add_metadata( 'site', 1, 'test_site_feta', 'cheese', false );

All appears to work okay, however this does not;

add_metadata( 'blog', 1, 'test_site_feta', 'cheese', false );

Think its a bug...until I had a closer look I had to use MySQL queries to add the site meta.

[leeml]

To be honest 'add_site_meta' is working for the blog meta table, I was looking at an instance where site meta needed to be set via a frontend extension for what is usually a user profile specific action. Hence the need to update the site meta table, in this case anyway.

Which is doable given the use of add_metadata.

It would be useful I guess if the site meta functions could work with the site meta table allowing for then existing site meta functions being renamed to blog meta. i.e. update_blogmeta and so on...

Hence the initial confusion I guess...everything else seems to be table specific i.e. post meta,term meta, user meta and so on.

[leeml]

I found the network option functions in the end, oh boy!

[callumbw95]

Hi @leeml,

I have taken a quick look into this and can confirm that the mentioned function is working correctly on the latest version. I am not sure if potentially there was an issue in the past that has been solved, but I cannot find any mention of this, or any other issues? One thing I did test out is that when the site is not a multisite this function "fails" correctly. However in a multisite environment this function does work as intended. As of such I don't believe this is an issue, and I will close this ticket. But if you do have anything else to add please reopen the ticket and we can continue the discussion! 😃

[peterwilsoncc]

Related: #61467.

The network options populate the wp_sitemeta table which can cause confusion.

There's also the confusion of referring to sites in the admin as blogs in code, and networks in the admin as sites in code for legacy and back-compat reasons.