Unable to pass _embed param to enveloped REST API requests

[spacedmonkey]

Added in #39696, developers can now selectively embed links. However this value is not passed down the enveloped requests.

Trac ticket: https://core.trac.wordpress.org/ticket/54015

Trac ticket: https://core.trac.wordpress.org/ticket/54015

[johnbillion]

Can we get a test for this?

[spacedmonkey]

Replying to johnbillion:

Can we get a test for this?

I had a look into this and is not easy to add a test here. Lots have to be mocked this change is deeply embed in the serve_request method. I was thinking about somehow exacting the logic, to make easier to test. Thoughts @johnbillion ?

[johnbillion]

I'm not surprised to be honest, I remember this from another ticket that touched the _embed parameter.

@TimothyBlynJacobs Thoughts?

[TimothyBlynJacobs]

I think we should be able to use expectOutputString and call serve_request after setting $_GET['embed'] to the value we want to test.

[spacedmonkey]

@TimothyBlynJacobs I am not sure what you mean there. Any chance you could put together a test for this or point in the direction of one.

[TimothyBlynJacobs]

Something along the lines of this:

$this->expectOutputString( 'json body that we expect' );

$_GET['embed'] = 'link';
rest_get_server()->serve_request('/endpoint/to/test');

Trac ticket: https://core.trac.wordpress.org/ticket/54015

[spacedmonkey]

I have updated the patch at ​#2544 with unit tests.

LGTM! Just some minor bits of feedback.

[spacedmonkey]

In 53110:

REST API: Use rest_parse_embed_param function in WP_REST_Server class.

Ensure that the value get parameter _embed that is passed to the envelope_response method, is run through the rest_parse_embed_param function.

Props Spacedmonkey, johnbillion, TimothyBlynJacobs.
Fixes #54015.