Make WordPress Core

Opened 2 years ago

Last modified 11 months ago

#54034 assigned enhancement

Update jQuery UI Touch Punch to the latest version

Reported by: hareesh-pillai's profile Hareesh Pillai Owned by: hareesh-pillai's profile Hareesh Pillai
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: External Libraries Keywords: has-patch needs-testing needs-testing-info dev-feedback changes-requested
Focuses: Cc:

Description

A new version of jQuery UI Touch Punch is available (v 0.2.3). However, this version was released 7 years ago and might have issues while updating.

Attachments (1)

54034.patch (8.6 KB) - added by aadilali 2 years ago.

Download all attachments as: .zip

Change History (17)

#1 @Hareesh Pillai
2 years ago

Looking further, it seems the project is abandoned, and a fork is available - https://github.com/RWAP/jquery-ui-touch-punch.

This appears to have fixed some of the issues reported regarding compatibility with the latest jQuery version, working on the latest devices etc. We should perhaps evaluate replacing with this fork instead.

Link to the list of issues in jQuery UI Touch Punch: https://github.com/furf/jquery-ui-touch-punch/issues.

@aadilali
2 years ago

#2 @aadilali
2 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

This ticket was mentioned in Slack in #core-test by hellofromtonya. View the logs.


2 years ago

#4 @Boniu91
2 years ago

  • Keywords needs-testing-info added

Hello @hareesh-pillai thank you for this ticket.

Could you share with us steps that we can take to test the patch?

#5 @hellofromTonya
2 years ago

  • Keywords dev-feedback added

Hey @azaozz and @Clorith, Should this jQuery UI Touch Punch update be committed for 5.9?

#6 @hellofromTonya
2 years ago

  • Milestone changed from 5.9 to 6.0

With 5.9 Beta 1 happening in a few hours, moving this to 6.0.

#7 @peterwilsoncc
2 years ago

@azaozz and @Clorith do you have thoughts on updating jQuery UI Touch Punch?

#8 @costdev
23 months ago

  • Milestone changed from 6.0 to 6.1

This ticket is still awaiting dev-feedback and testin. As we are now beyond feature freeze for 6.0, I'm moving this ticket to the 6.1 milestone.

If this ticket moves towards being committed, feel free to move it back into the 6.0 milestone.

#9 @davidbaumwald
17 months ago

  • Milestone changed from 6.1 to Future Release

With 6.1 Beta 1 releasing tomorrow and this ticket still needing discussion and a decision, this is being moved to Future Release.

If any maintainer/committer wishes to assume ownership of this during a specific cycle, feel free to update the milestone at that time.

Last edited 17 months ago by davidbaumwald (previous) (diff)

#10 @desrosj
17 months ago

I chatted with @Clorith about this one in Slack. Want to share our DM for transparency:

I wonder if that's a duplicate or something, I know I brought up something similar somewhere, trying to remember where though. Ideally we don't want to maintain and take the risk of an abandoned library

I couldn't find the talk about abandoned JS libraries, but I think it's something to take up with the JS team before we make a decision there, especially since there's so many forks (at least in this case), that may differ at varying points, and we also need to ensure backwards compatibility with whatever fork we end up going with (if any), or have to take on the responsibility of maintaining a custom fork in our own vendor folder.

#11 @gerarde
14 months ago

A fork of the original Touch Punch is being actively maintained, has addressed a number of oustanding issues with the original, and has even added support for Microsoft devices.

https://github.com/RWAP/jquery-ui-touch-punch

Last edited 14 months ago by gerarde (previous) (diff)

This ticket was mentioned in PR #3812 on WordPress/wordpress-develop by RWAP.


14 months ago
#12

Updates early version (which has not been updated in many years and contains many bugs). Uses the code from maintained version: https://github.com/RWAP/jquery-ui-touch-punch/blob/master/jquery.ui.touch-punch.js

The touch-punch Code has been tested on a wide range of touch devices to allow touch devices to use mouse controls in jQuery UI

For changes and issues - please submit to the original repository: https://github.com/RWAP/jquery-ui-touch-punch/blob/master/jquery.ui.touch-punch.js

#13 @mukesh27
14 months ago

  • Keywords changes-requested added

Thanks @RWAP for PR, I left one feedback on PR to change script version.

RWAP commented on PR #3812:


14 months ago
#14

OK I have updated the version number also in the script-loader.php

@peterwilsoncc commented on PR #3812:


14 months ago
#15

@RWAP Thanks for the patch, is the correct as the change log for the uncompressed code? https://github.com/furf/jquery-ui-touch-punch/compare/master...RWAP:jquery-ui-touch-punch:master

RWAP commented on PR #3812:


11 months ago
#16

@RWAP Thanks for the patch, is the correct as the change log for the uncompressed code? furf/jquery-ui-touch-punch@master...RWAP:jquery-ui-touch-punch:master

No - as the old code has not been maintained and no-one looks after the repository, it seemed better to treat it as a brand new bit of code:

https://github.com/RWAP/jquery-ui-touch-punch

Note: See TracTickets for help on using tickets.