Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#54035 closed defect (bug) (fixed)

Update Jcrop to the latest version

Reported by: hareesh-pillai's profile Hareesh Pillai Owned by: davidbaumwald's profile davidbaumwald
Milestone: 6.0 Priority: normal
Severity: normal Version:
Component: External Libraries Keywords: good-first-bug has-patch commit assigned-for-commit add-to-field-guide
Focuses: Cc:

Description

A new version of Jcrop is available (v0.9.15).

List of changes: https://github.com/tapmodo/Jcrop/compare/v0.9.12...v0.9.15

These look like minor changes and can be updated without much issues.

Attachments (1)

54035.diff (42.1 KB) - added by karpstrucking 3 years ago.

Download all attachments as: .zip

Change History (9)

@karpstrucking
3 years ago

#1 @karpstrucking
3 years ago

  • Keywords has-patch added; needs-patch removed

attachment:54035.diff updates wp-includes/js/jcrop/jquery.Jcrop.min.css and wp-includes/js/jcrop/jquery.Jcrop.min.js - I hope I'm correct in understanding those are the only two relevant files! :)

#2 @hellofromTonya
3 years ago

  • Milestone changed from 5.9 to 6.0

5.9 Beta 1 is happening in less than 30 minutes. I'm sorry this ticket didn't get a review and testing in time. Moving it to 6.0.

#3 @davidbaumwald
3 years ago

  • Keywords commit assigned-for-commit added

After conferring with @SergeyBiryukov about this, this seems to have been replaced with imgAreaSelect([14907]) and is no longer used by Core.

Sergey's recommendation:

I think adding a comment might be a good idea, similar to the one added for Cropper in [11742]:
// Not used in core, replaced by imgAreaSelect.

I think it's safe to update to 0.9.15 if there are no major changes.
It was updated to 0.9.12 while being already unused: [25549]

Last edited 3 years ago by davidbaumwald (previous) (diff)

#4 @davidbaumwald
3 years ago

  • Owner set to davidbaumwald
  • Status changed from new to accepted

#6 @davidbaumwald
3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 52989:

External Libraries: Update Jcrop to version 0.9.15.

For a full list of changes, see https://github.com/tapmodo/Jcrop/compare/v0.9.12...v0.9.15.

This change also adds a comment in script-loader.php indicating that this library is no longer used by core.

Follow-up to [10846], [10863], [11015], [21633], [25549].

Props hareesh-pillai, karpstrucking, SergeyBiryukov.
Fixes #54035.

#7 @milana_cap
3 years ago

  • Keywords needs-dev-note added

Marking for dev note but really needs only mentioning in Field guide.

#8 @milana_cap
3 years ago

  • Keywords add-to-field-guide added; needs-dev-note removed
Note: See TracTickets for help on using tickets.