Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#54041 closed defect (bug) (fixed)

Docs: Consistent use of "sign-up/sign up/signup" in wp-signup.php

Reported by: audrasjb's profile audrasjb Owned by: peterwilsoncc's profile peterwilsoncc
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Login and Registration Keywords: has-patch commit
Focuses: docs Cc:


As a follow-up to #41566, let's use a consistent writing for sign-up/signup in wp-signup.php docblocks.

I believe the correct use is:

  1. "sign up" in a verbal phrase, which is used to refer to an action of signing up. Example: "Shows a form for a visitor to sign up for a new user account."
  2. "sign-up" or "signup" when used as a noun or an adjective. Example: "Fires when the site or user sign-up process is complete."

As for now, the wp-signup.php file use the three forms. For consistency, I propose to use "sign up" on verbal phrases (which would be consistent with "log in", already used in the same file), and "sign-up" for the second case, which is the most current use (noun or adjective) in this file.

For reference:

Attachments (1)

54041.diff (3.8 KB) - added by audrasjb 3 years ago.

Download all attachments as: .zip

Change History (5)

3 years ago

#1 @JeffPaul
3 years ago

  • Keywords has-patch added

This ticket was mentioned in Slack in #core-test by hellofromtonya. View the logs.

3 years ago

#3 @audrasjb
3 years ago

  • Keywords commit added

[silent 5.9 bugscrub]

The patch still applies cleanly against trunk, let's mark it ready for commit.

#4 @peterwilsoncc
3 years ago

  • Owner set to peterwilsoncc
  • Resolution set to fixed
  • Status changed from new to closed

In 51930:

Docs: Use sign-up & signup consistently in wp-signup.php.

In the docblocks throughout wp-signup.php use sign up for verbs and sign-up for nouns.

Props audrasjb, jeffpaul.
Fixes #54041. See #53399.

Note: See TracTickets for help on using tickets.