Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #54042, comment 32


Ignore:
Timestamp:
05/07/2022 02:24:15 PM (3 years ago)
Author:
apokalyptik
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #54042, comment 32

    initial v1  
    1010> The `$arg_identifiers` are separate so I can easily [https://github.com/craigfrancis/wordpress-develop/blob/db5ab0881c5740f9ec6df9134709ae43ebbf3689/src/wp-includes/wp-db.php#L1641 escape them differently], and to trigger the "cannot be used for both String and Identifier escaping" error. As in, if someone tried to use the same value in both a string/number and identifier context (odd, but it might happen), because they cannot be escaped in the same way, I need to reject that, and ask them to provide the value twice, e.g.
    1111
    12 Right. I'm suggesting that a single array in the format of something like `$index[ $arg_id ] = array( $boolVariadic, $boolIdentifier[, ...] );` would let you 1) pull the data without doing an array value search with `in_array` (multiple times in some cases.) Just storing the metadata in a better indexed format like this removes the value searching.
     12Right. I'm suggesting that a single array in the format of something like `$index[ $arg_id ] = array( $boolVariadic, $boolIdentifier[, ...] );` would let you pull the data without doing an array value search with `in_array` (multiple times in some cases.) Just storing the metadata in a better indexed format like this removes the value searching.
    1313
    1414