Add visibility field to Post type controller

[spacedmonkey]

Original ticket from gutenberg repo ​34443.

Add a new field to the Post types REST API controller called visibility. This field would be work similarly to the visibility field found in the taxonomy REST API controller.

See this issue for more information ​https://github.com/WordPress/gutenberg/issues/34443

Trac ticket: https://core.trac.wordpress.org/ticket/54055

[spacedmonkey]

There are now some basic unit tests that pass.

We may want to look at is_post_type_viewable.

We may want to look at is_post_type_viewable.

This data is already in the endpoint.

​https://github.com/WordPress/wordpress-develop/blob/26c0800c4625e1668bf91f97319abebb9ad6bd8f/src/wp-includes/rest-api/endpoints/class-wp-rest-post-types-controller.php#L197-L199

Ah, my mistake. So should we still be exposing public and publicly_queryable then?

So should we still be exposing public and publicly_queryable then?

public should probably not be exposed, it's pretty meaningless. A post type can be public without being viewable by registering a CPT with these arguments:

{{{php
[

'public' => true,
'exclude_from_search' => true,
'publicly_queryable' => false,
'show_in_nav_menus' => false,
'show_ui' => false,
'show_in_rest' => false,

]
}}}

publicly_queryable is of more use as it's what determines if a post type is viewable for CPTs but going via the helper function is_post_type_viewable() is the safest result.

@peterwilsoncc Good catch. I have removed it now.

We should be ditching publicly_queryable as well then, right? Since we are already exposing the correct computed value?

[TimothyBlynJacobs]

In 51959:

REST API: Add visibility information to the Post Types controller.

Props spacedmonkey, peterwilsoncc.
Fixes #54055.

Merged in https://core.trac.wordpress.org/changeset/51959.