#54056 closed defect (bug) (fixed)
Twenty Twenty: Editor title alignment broken by Gutenberg plugin v11.4.0 updates
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.9 | Priority: | normal |
Severity: | normal | Version: | 5.9 |
Component: | Bundled Theme | Keywords: | has-patch has-screenshots commit |
Focuses: | css | Cc: |
Description
The in-editor styles for the post/page title no longer properly update the alignment or size of the post/page title after the implementation of the rich text hook for post titles in Gutenberg 11.4.0.
In the screenshot below, styling under Gutenberg 11.3.0 can be seen on the left, and 11.4.0 on the right:
It looks like editor styles are targeting
.editor-styles-wrapper .wp-block h1
instead of
.editor-styles-wrapper h1.wp-block
that Gutenberg is now outputting.
This change also introduces markup changes that break the current targeting the post title of
.editor-styles-wrapper .editor-post-title__block .editor-post-title__input
Under the new markup
Finally, the title block itself was previously wrapped in an additional div
that is no longer present. This div
was generating the margins that helped to center the title above the post content.
Attachments (7)
Change History (25)
This ticket was mentioned in Slack in #core-test by mai21. View the logs.
3 years ago
#3
@
3 years ago
- Resolution set to invalid
- Status changed from new to closed
Could reproduce it as follow:
1- Fresh install for WP version 5.8.1
2- Switch theme to Twenty Twenty
3- Open edit view of the sample page
4- On another fresh version of WP using 5.9-alpha-51857
5- Install on the latest WP the Gutenberg plugin (v 11.5.1)
6- Open edit of the same sample page
Actual: text styling is different
Notes:
- tested the same scenario on Twenty Nineteen => page edit was almost the same with very little shift (I think due to adding Author is page variables)
- Tested on Twenty Twenty One and titles were different in style as well + the shift mentioned above
#4
@
3 years ago
- Resolution invalid deleted
- Status changed from closed to reopened
opening it as it was closed by mistake
#5
@
3 years ago
- Keywords needs-patch added
- Milestone changed from Awaiting Review to 5.8.2
Moving into 5.8.2 milestone.
#7
@
3 years ago
- Keywords needs-refresh added
- Milestone changed from 5.8.2 to 5.9
There are currently no plans to include bundled theme updates with 5.8.2, so going to bump this to 5.9.
I'm not sure if 54056.patch is the right approach. The style definition meant to target this is right below the additions in 54056.patch. I think it would be great if that one could be altered instead.
Also, there are definitions for several breakpoints in the stylesheet. The patch only addresses one of those, and assigns a different size than the definition below it (64px in this instance).
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
3 years ago
#11
@
3 years ago
- Keywords has-patch needs-refresh removed
Maybe we should wait for the related Gutenberg code to be merged into trunk, since for now we are trying to fix a bug that doesn’t exist in Core :)
(removing has-patch
as the existing one doesn't apply to this issue)
#12
follow-up:
↓ 13
@
3 years ago
- Keywords has-patch added
The patch restores the font and font size at each breakpoint, plus the title is centered again.
However, the title does not have the top and bottom padding that used to be in the block editor's stylesheet. If that's important, I think it should be added in the editor styles again, not individual themes.
#13
in reply to:
↑ 12
@
3 years ago
- Keywords needs-testing added
Replying to sabernhardt:
However, the title does not have the top and bottom padding that used to be in the block editor's stylesheet. If that's important, I think it should be added in the editor styles again, not individual themes.
It doesn't look like a critical change :)
I'm going to test the patch right now.
This ticket was mentioned in PR #1976 on WordPress/wordpress-develop by audrasjb.
3 years ago
#14
Trac ticket: https://core.trac.wordpress.org/ticket/54056
#17
@
3 years ago
- Resolution set to fixed
- Status changed from accepted to closed
Fixed in changeset [52271].
The commit doesn't appear due to a Trac issue, so marking this ticket as fixed
manually ✅
hellofromtonya commented on PR #1976:
3 years ago
#18
Committed via https://core.trac.wordpress.org/changeset/52271.
Update: It turns out the change that triggered this issue was actually the removal of the wrapper div.
Some of the fixes for this have been made directly in Gutenberg, but it looks like there may still be some theme-specific changes to be made if needed.