#54083 closed task (blessed) (fixed)
Update the About page for 5.8.1
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.8.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Help/About | Keywords: | has-patch |
Focuses: | administration | Cc: |
Description
Let's update the WP-Admin about page with the 5.8.1 changes.
Attachments (2)
Change History (14)
This ticket was mentioned in PR #1661 on WordPress/wordpress-develop by circlecube.
21 months ago
#1
- Keywords has-patch added
#2
@
21 months ago
- Keywords needs-refresh added
Hello @circlecube and thank you for putting this together.
We should rather use the existing strings provided at the end of the about.php
file.
So
<strong>Version %1$s</strong> fixed %2$s bugs.
Should be replaced with
<strong>Version %1$s</strong> addressed %2$s bugs.
and same for the singular string.
Also, the number of fixed bugs is not consistent: 11 in the _n
function, and 41 in the number_format_i18n
function :)
Otherwise the patch looks good to me (see screenshot below).
#3
@
21 months ago
- Keywords needs-refresh removed
Merci @audrasjb! Correct on all accounts, I've updated the PR to incorporate these updates.
#4
@
21 months ago
We'll also want to include the fixes from the Gutenberg side. Looks like there were fixes for 20 issues that were cherry-picked for 5.8.1.
#5
@
21 months ago
Hi @circlecube, I think we have to use border and background color for the 5.8.1 update block
Please check the attached screenshot.
#6
@
21 months ago
@mukesh27 there is no obligation in using a border for this block, the design is different for each about page. The big black border was consistent with the 5.7 about page design but IMO it look quite harsh on 5.8's :)
#7
@
21 months ago
@audrasjb Thanks for the reply.
Can we highlight that update notice for better understanding?
#8
@
21 months ago
I'm not sure the blue color used for links would be accessible on a blueish background… 😬
#9
@
21 months ago
- Owner set to desrosj
- Resolution set to fixed
- Status changed from new to closed
In 51767:
#10
in reply to:
↑ description
;
follow-up:
↓ 11
@
21 months ago
Replying to circlecube:
Let's update the WP-Admin about page with the 5.8.1 changes.
Trac ticket: https://core.trac.wordpress.org/ticket/54083