Undefined index 'posts_per_page' in ajax-actions.php

[davidwebca]

This is a follow-up to #53773.

The fix was unsifficient to prevent some errors, such as 'undefined index: posts_per_page' which I am getting right now on line 3006 in 5.8.1.

The problem comes from the fact that we are trying to get "posts_per_page" on the query sub-object directly instead of using getter methods on the WP_Query instance. With the getter methods of WP_Query, a default value is always provided if none is set by the user and defaults to 12 like the WordPress global posts_per_page value.

Line 3006 should be changed from

$posts_per_page = (int) $attachments_query->query['posts_per_page'];

to

$posts_per_page = (int) $attachments_query->get('posts_per_page');

[SergeyBiryukov]

Hi there, welcome back to WordPress Trac! Thanks for the ticket.

Moving to 5.8.2, as this was introduced in [51145].

Trac ticket: https://core.trac.wordpress.org/ticket/54129

[mukesh27]

PR added with required change.

Feel free to update

[SergeyBiryukov]

In 51982:

Media: Use WP_Query::get() method to retrieve the posts_per_page value in wp_ajax_query_attachments().

This avoids a PHP notice and ensures that a default value is always provided if none is set by the user.

Follow-up to [51145], [51485].

Props davidwebca, mukesh27.
Fixes #54129.

[SergeyBiryukov]

In 51983:

Media: Use WP_Query::get() method to retrieve the posts_per_page value in wp_ajax_query_attachments().

This avoids a PHP notice and ensures that a default value is always provided if none is set by the user.

Follow-up to [51145], [51485].

Props davidwebca, mukesh27, circlecube, desrosj.
Merges [51982] to the 5.8 branch.
Fixes #54129.