Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#54146 closed defect (bug) (fixed)

The extension "webp" is missing

Reported by: almendron's profile almendron Owned by: adamsilverstein's profile adamsilverstein
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.8.1
Component: Media Keywords:
Focuses: Cc:


File wp-includes/js/media-views.js
Line 3449

return /\.(jpe?g|png|gif)$/i.test( attachment.get('filename') );

File wp-includes/js/dist/block-editor.js
Line 26680

}) => /^image\/(?:jpe?g|png|gif)$/.test(type)); // Only process files if no HTML is present.

Line 30251

}) => /^image\/(?:jpe?g|png|gif)$/.test(type)).map(file => `<img src="${Object(external_wp_blob_["createBlobURL"])(file)}">`).join('');

File wp-includes/js/plupload/wp-plupload.js
Line 379

mage = /(?:jpe?g|png|gif)$/i.exec( );

Change History (7)

#1 @adamsilverstein
3 years ago

  • Owner set to adamsilverstein
  • Status changed from new to assigned

Hi @almendron - thanks for the bug report.

Did you notice any effect of the missing webp extension in each of these cases? I agree thee likely need updating, however it would be good to understand what each does so we can document and test that the change fixes an issue.

#2 @almendron
3 years ago

File wp-includes/js/media-views.js: #53917

Rest of cases: not verified.

Last edited 3 years ago by SergeyBiryukov (previous) (diff)

#3 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 5.9

#4 @adamsilverstein
3 years ago

I believe the usage in wp-includes/js/dist/block-editor.js comes from Gutenberg.

I opened this PR to updates usages in Gutenberg (although I don't know exactly how these are used, I assume webp should be added):

cc: @gziolo

This ticket was mentioned in Slack in #core by audrasjb. View the logs.

3 years ago

#6 @adamsilverstein
3 years ago

This is fixed upstream in which I just merged. Marking this ticket as resolved.

@almendron let me know if you still see this issue anywhere, thanks again for raising.

#7 @adamsilverstein
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.