Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#54162 closed task (blessed) (fixed)

Update GetID3 to version 1.9.21

Reported by: jrf's profile jrf Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: External Libraries Keywords: needs-patch php81
Focuses: Cc:

Description

GetID3 1.9.21 has just been released and includes preliminary PHP 8.1 support, as well as a variety of bugfixes.

The version included with WP should be updated.

Full details:

I've NOT reviewed the diff yet, but would strongly recommend an update at the earliest convenience due to the PHP 8.1 fixes being included.

Previously: [47601], [48278]
Related: #53635

Attachments (1)

54162.diff (110.1 KB) - added by SergeyBiryukov 2 years ago.

Download all attachments as: .zip

Change History (9)

#1 @hellofromTonya
2 years ago

  • Keywords php81 added

#2 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 51900:

External Libraries: Update getID3 to version 1.9.21.

The latest version includes preliminary PHP 8.1 support, as well as a variety of bug fixes.

Release notes: https://github.com/JamesHeinrich/getID3/releases/tag/v1.9.21

A full list of changes in this update can be found on GitHub:
https://github.com/JamesHeinrich/getID3/compare/v1.9.20...v1.9.21

This commit also includes PHPCS adjustments previously made for a passing PHP Compatibility scan.

Follow-up to [47601], [47737], [47902], [48278], [49621], [50714].

Props jrf, SergeyBiryukov.
Fixes #54162.

#3 @SergeyBiryukov
2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Looks like [51900] caused unit test failures:

There were 3 errors:

1) Tests_Media::test_wp_read_audio_metadata_adds_creation_date_with_mp4
Undefined index: created_timestamp

/var/www/tests/phpunit/tests/media.php:2557

2) Tests_Media::test_wp_read_video_metadata_adds_creation_date_with_quicktime
Undefined index: created_timestamp

/var/www/tests/phpunit/tests/media.php:2567

3) Tests_Media::test_wp_read_video_metadata_adds_creation_date_with_mp4
Undefined index: created_timestamp

/var/www/tests/phpunit/tests/media.php:2577

#4 @SergeyBiryukov
2 years ago

In 51901:

External Libraries: Revert [51900] for now to investigate test failures.

See #54162.

#5 @SergeyBiryukov
2 years ago

#54285 was marked as a duplicate.

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


2 years ago

@SergeyBiryukov
2 years ago

#7 @SergeyBiryukov
2 years ago

Tracked the test failures to this commit setting the $options_audiovideo_quicktime_ReturnAtomData property to false instead of true by default.

For WordPress, this leads to the data returned by $id3::analyze() no longer containing the moov element, which, among other things, includes the creation_time_unix field that wp_get_media_creation_timestamp() uses to retrieve the creation time.

Simply setting the property to true makes the tests pass again, see 54162.diff.

#8 @SergeyBiryukov
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 52254:

External Libraries: Update getID3 to version 1.9.21.

The latest version includes preliminary PHP 8.1 support, as well as a variety of bug fixes.

Release notes: https://github.com/JamesHeinrich/getID3/releases/tag/v1.9.21

A full list of changes in this update can be found on GitHub:
https://github.com/JamesHeinrich/getID3/compare/v1.9.20...v1.9.21

This commit also includes:

  • Setting the $options_audiovideo_quicktime_ReturnAtomData property (now false by default) to true in wp_read_video_metadata() and wp_read_audio_metadata() in order to get the created_timestamp value.
  • PHPCS adjustments previously made for a passing PHP Compatibility scan.

Follow-up to [47601], [47737], [47902], [48278], [49621], [50714].

Props jrf, SergeyBiryukov.
Fixes #54162.

Note: See TracTickets for help on using tickets.