Make WordPress Core

Opened 5 weeks ago

Last modified 9 days ago

#54162 reopened task (blessed)

Update GetID3 to version 1.9.21

Reported by: jrf Owned by: SergeyBiryukov
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: External Libraries Keywords: needs-patch php81
Focuses: Cc:


GetID3 1.9.21 has just been released and includes preliminary PHP 8.1 support, as well as a variety of bugfixes.

The version included with WP should be updated.

Full details:

I've NOT reviewed the diff yet, but would strongly recommend an update at the earliest convenience due to the PHP 8.1 fixes being included.

Previously: [47601], [48278]
Related: #53635

Change History (5)

#1 @hellofromTonya
5 weeks ago

  • Keywords php81 added

#2 @SergeyBiryukov
3 weeks ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 51900:

External Libraries: Update getID3 to version 1.9.21.

The latest version includes preliminary PHP 8.1 support, as well as a variety of bug fixes.

Release notes: https://github.com/JamesHeinrich/getID3/releases/tag/v1.9.21

A full list of changes in this update can be found on GitHub:

This commit also includes PHPCS adjustments previously made for a passing PHP Compatibility scan.

Follow-up to [47601], [47737], [47902], [48278], [49621], [50714].

Props jrf, SergeyBiryukov.
Fixes #54162.

#3 @SergeyBiryukov
3 weeks ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Looks like [51900] caused unit test failures:

There were 3 errors:

1) Tests_Media::test_wp_read_audio_metadata_adds_creation_date_with_mp4
Undefined index: created_timestamp


2) Tests_Media::test_wp_read_video_metadata_adds_creation_date_with_quicktime
Undefined index: created_timestamp


3) Tests_Media::test_wp_read_video_metadata_adds_creation_date_with_mp4
Undefined index: created_timestamp


#4 @SergeyBiryukov
3 weeks ago

In 51901:

External Libraries: Revert [51900] for now to investigate test failures.

See #54162.

#5 @SergeyBiryukov
9 days ago

#54285 was marked as a duplicate.

Note: See TracTickets for help on using tickets.