WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #54173, comment 7


Ignore:
Timestamp:
10/05/2021 04:44:29 PM (4 months ago)
Author:
sabernhardt
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #54173, comment 7

    initial v1  
    1 I'm not sure we should ''automatically'' replace a visible phone number with an icon in Twenty Twenty-One. I have added phone number links—among other text links—on clients' sites, where I would not want the number changed to an icon only. On the other hand, this change would make the call link visually consistent with (most) other links in the secondary menu location. Ultimately, this could benefit the majority of users who add links in that menu, but I think some other people would not be happy about it.
     1I'm not sure we should ''automatically'' replace a visible phone number with an icon in Twenty Twenty-One. I have added phone number links—among other text links—on clients' sites, where I would not want the number changed to an icon only. On the other hand, this change would make the call link visually consistent with (most) other links in the secondary menu location. Ultimately, this might benefit the majority of users who add links in that menu, but I think some other people would not be happy about it.
    22
    33In Seedlet 1.1.7, that theme added a [https://themes.trac.wordpress.org/browser/seedlet/1.1.13/classes/class-seedlet-svg-icons.php#L242 phone icon] to the social group, after Twenty Twenty-One became available. With bundled themes, though, we closed requests for new Twenty Twenty icons in favor of creating a filter (see ticket:48713#comment:7). (For what it's worth, I would prefer a phone icon instead of the generic link icon in Twenty Seventeen and Twenty Twenty.)