Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #54177, comment 2


Ignore:
Timestamp:
09/24/2021 10:06:17 AM (4 years ago)
Author:
costdev
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #54177, comment 2

    v1 v2  
    1 There were new tests committed upstream that didn't identify their visibility just prior to me creating the initial PR.
     1There were new tests committed upstream that didn't identify their visibility just prior to me creating the initial PR, so this is still an ongoing standards issue.
    22
    33We should try to find a way to ensure that all tests going forward have their visibility identified prior to commit. Ideally this would be added to the PHP coding standards, if they can detect class methods vs nested methods, so that committers don't have to spend the time to communicate this to contributors, which could create quite a delay.