Make WordPress Core

Opened 4 months ago

Last modified 2 months ago

#54188 new defect (bug)

Different theme screenshot sizes are displayed in the customizer preview

Reported by: poena Owned by:
Milestone: 6.0 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch needs-unit-tests needs-testing
Focuses: Cc:

Description (last modified by poena)

On the Add themes page in the WordPress admin you can select "Live Preview" or "Preview" to preview themes in the customizer.

In the preview, the customizer sidebar shows a screenshot of the theme.
This screenshot is displayed in different sizes depending on the aspect ratio of the screenshot that is in the theme folder.

The screenshot size should be enforced and the screenshot should be consistent and displayed in the same size for all themes.

Related meta ticket: https://meta.trac.wordpress.org/ticket/5834

Attachments (2)

customizer-preview-theme-installation.png (72.7 KB) - added by poena 4 months ago.
Different image sizes in the customizer preview
54188.diff (1.1 KB) - added by karpstrucking 4 months ago.

Download all attachments as: .zip

Change History (6)

@poena
4 months ago

Different image sizes in the customizer preview

#1 @poena
4 months ago

  • Description modified (diff)

@karpstrucking
4 months ago

#2 @karpstrucking
4 months ago

  • Keywords has-patch added; needs-patch removed

took a stab at this, basically just a mimic of the approach used on /wp-admin/themes.php

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


2 months ago

#4 @audrasjb
2 months ago

  • Keywords needs-unit-tests needs-testing added
  • Milestone changed from 5.9 to 6.0

As per today's bug scrub, it looks like this patch still needs testing and unit tests. Moving for 6.0 consideration.

Note: See TracTickets for help on using tickets.