PHP fileinfo extention identifies JSON as text/plain; wp_check_filetype_and_ext then prevents upload

[dashifen]

For hosts that make available the PHP fileinfo extension, uploaded files of mime type application/json are identified by that extension as text/plain. Within the wp_check_filetype_and_ext function, it's noted that "a few common file types are occasionally detected as text/plain", but application/json is not listed as one of those common types. For reference, the following types are listed: csv, rtf, tsv, and vtt.

I propose adding application/json to this list. Otherwise, I believe it may be impossible to upload a JSON file on a host that uses this extension.

[mukesh27]

Hi there! thanks for the ticket and patch.

Your patch fileinfo-json-fix.diff​ removed application/json from the file.

Here are a couple of resources to help you get started creating and submitting a patch:

• ​Creating a patch with the command line (as I noticed in the pngs you're using git)
• ​FAQ for New Contributors

For creating the patch

• Checkout the master branch (the images show you are on the 5.8 branch)
• Sync your copy of master to the upstream wordpress/wordpress-develop repo, i.e. by pulling the latest changes from upstream and then merging these changes into your local copy
• Add the comment change
• Then svn diff > 54193.diff to create the patch file
• Then upload that patch file to this ticket

[aezazshekh]

Added application/json to this list

[dashifen]

Ugh ... I diffed in the wrong order. 😊