WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#5421 closed defect (bug) (duplicate)

Commas within urls dont get parsed correctly (Pingback)

Reported by: torty Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.3.1
Component: Pings/Trackbacks Keywords:
Focuses: Cc:

Description

Hi,

Wordpress does not extract urls with a "," like
http://www.myWebsite.de/tests/digicam/0,39030924,39159407,00/enorm+anpassungsfaehig+casio+exilim+zoom+ex_z1080+video.htm

Returns as URL : http://www.cnet.de/tests/digicam/0

After looking at the code i think we found the problem:

the do_enclose function uses this regular expression:

$ltrs = '\w';
$gunk = '/#~:.?+=&%@!\-';
$punc = '.:?\-';
$any = $ltrs . $gunk . $punc;

preg_match_all("{\b http : [$any] +? (?= [$punc] * [$any] | $)}x", $content, $post_links_temp);

which is missing ',' at all.
As far as we found out commas are allowed within urls.
See also: http://gbiv.com/protocols/uri/rfc/rfc3986.html#examples

Maybe sombody could fix that so that sites with 'comma'-urls could get pinged also.

Thanks

Torsten

Change History (2)

comment:1 lloydbudd6 years ago

  • Milestone changed from 2.3.2 to 2.5

comment:2 Denis-de-Bernardy5 years ago

  • Component changed from General to Pings/Trackbacks
  • Milestone 2.9 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

there is a dup of this one with a candidate patch.

Note: See TracTickets for help on using tickets.