WordPress.org

Make WordPress Core

Opened 2 months ago

Last modified 2 months ago

#54217 new defect (bug)

Menu Screen has some UI inconsistency issue

Reported by: juhise Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 5.8
Component: Menus Keywords: has-patch has-screenshots
Focuses: ui, css, administration Cc:

Description (last modified by sabernhardt)

Bulk Select button on menu screen on top and bottom doesn't have the equal margin from top and bottom, Refer Screenshot bulk-select-margin.png

After applying the patch, the screen looks like this, refer bulk-select-after-fix.png

Made sure it doesn't break anything else, after applying the fix for it, menu items margin got disturbed so applied fix for that as well, refer menu-item-margin.png

Add menu items from the column on the left. padding of this also got disturbed so fixed this by adding

.nav-menus-php #post-body-content .post-body-plain {
	margin-bottom: 0;
	padding: 0.1em 0;
}

Refer Screenshots: menu-item-colum-left.png & menu-item-colum-left-after-fix.png


Attachments (11)

bulk-select-margin.png (49.6 KB) - added by juhise 2 months ago.
Initital Issue of Bulk Select margin
bulk-select-after-fix.png (48.8 KB) - added by juhise 2 months ago.
After fix bulk select margin
menu-item-margin.png (59.7 KB) - added by juhise 2 months ago.
Menu Items margin got disturbed due to fix for Bulk Select button
menu-item-after-fix.png (55.8 KB) - added by juhise 2 months ago.
After Fix
menu-item-colum-left.png (49.6 KB) - added by juhise 2 months ago.
menu-item-colum-left-after-fix.png (51.9 KB) - added by juhise 2 months ago.
Top Space.png (36.0 KB) - added by mukesh27 2 months ago.
top-spacing-after-fix.png (71.6 KB) - added by juhise 2 months ago.
Top Spacing after fix
new-menu-with-no-title-5.8.png (46.4 KB) - added by juhise 2 months ago.
With 5.8.1
new-menu-with-no-title-after-current-change.png (47.2 KB) - added by juhise 2 months ago.
After this ticket fix
new-menu-with-no-title-after-fix.png (36.5 KB) - added by juhise 2 months ago.
After adding fix for this

Download all attachments as: .zip

Change History (16)

@juhise
2 months ago

Initital Issue of Bulk Select margin

@juhise
2 months ago

After fix bulk select margin

@juhise
2 months ago

Menu Items margin got disturbed due to fix for Bulk Select button

@juhise
2 months ago

After Fix

This ticket was mentioned in PR #1730 on WordPress/wordpress-develop by juhi123.


2 months ago

#2 @sabernhardt
2 months ago

  • Component changed from General to Menus
  • Description modified (diff)
  • Focuses administration added
  • Version changed from trunk to 5.8

#3 @mukesh27
2 months ago

Hi there!

Thanks for the ticket and patch.

Can you please adjust the top space for Bulk select when there is a menu item in the menu?

@mukesh27
2 months ago

#4 @juhise
2 months ago

Hey @mukesh27

Thanks for sharing this issue, I have fixed this, hope it doesn't create any other issue.

@juhise
2 months ago

Top Spacing after fix

#5 @juhise
2 months ago

Added one more fixhttps://github.com/WordPress/wordpress-develop/pull/1730/commits/307b2094480d1cb0da3ad0b11a19c45abdb07d9f, for new menu menu when there was no title Give your menu a name, then click Create Menu. message doesn't have proper spacing. Even in 5.8 it didn't have consistent spacing from top and bottom
Attaching few screenshots new-menu-with-no-title-5.8.png new-menu-with-no-title-after-current-change.png new-menu-with-no-title-after-fix.png

Last edited 2 months ago by juhise (previous) (diff)

@juhise
2 months ago

With 5.8.1

@juhise
2 months ago

After this ticket fix

@juhise
2 months ago

After adding fix for this

Note: See TracTickets for help on using tickets.