#54223 closed defect (bug) (fixed)
Change the version of PHP 5.6 used for unit tests
Reported by: | desrosj | Owned by: | desrosj |
---|---|---|---|
Milestone: | 5.9 | Priority: | normal |
Severity: | normal | Version: | 5.7 |
Component: | Build/Test Tools | Keywords: | commit fixed-major |
Focuses: | Cc: |
Description
Since September 30, 2021, the PHPUnit tests for Core have failed to run on PHP 5.6. This coincides with the expiration of the DST Root CA X3 certificate, which results in some scenarios where certificates generated by the Let's Encrypt CA as having an expired trust chain.
For testing PHP 5.6, the 5.6.20 patch version is currently used, even though the last version of PHP 5.6 released was 5.6.40. This was an intentional decision in #50401 because 5.6.20 is the oldest version of PHP 5.6 that is currently supported by WordPress (see #46594).
For outdated branches of PHP still supported, it has been common practice to test the latest patch version of each, so the same can be done for PHP 5.6 to fix the SSL certificate issue.
Change History (13)
#4
follow-up:
↓ 6
@
3 years ago
- Keywords fixed-major added
- Resolution fixed deleted
- Status changed from closed to reopened
Accidentally committed [51889] to 5.8 and not trunk
. Going to merge that change into trunk
now.
Also, I think it's fine to leave this as is going forward. A few points from @dd32 on #46594:2:
Basically, 54% use the latest 5.6.40, 95% are 5.6.30 and above, and 99% are 5.6.20 and above
Most of the PHP 5.6 fixes after 5.6.25 seem to be security-related, and that's the point I stopped looking into it.
This was almost 3 full years ago now, so I'm sure that many of the remaining 5% on PHP < 5.6.30 have been updated, and there is very little to no benefit to testing on 5.6.20 instead of 5.6.40.
#6
in reply to:
↑ 4
@
3 years ago
Replying to desrosj:
Also, I think it's fine to leave this as is going forward. A few points from dd32 on #46594:2:
Basically, 54% use the latest 5.6.40, 95% are 5.6.30 and above, and 99% are 5.6.20 and above
As of today, of the PHP 5.6 users; 80% are 5.6.40 now, 5.6.31+ is 90%, 5.6.30+ is 95%, 5.6.21+ is 99%.
there is very little to no benefit to testing on 5.6.20 instead of 5.6.40.
Zero benefit, agreed.
This ticket was mentioned in Slack in #core by sergey. View the logs.
3 years ago
#8
@
3 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening this to backport through 5.6. While the tests are not breaking currently for those branches, changing it now will prevent this issue from potentially happening in the future and prevent confusion using different versions of PHP 5.6.
The first instance of the failure for reference.