#54239 closed task (blessed) (fixed)
tests for wp_fuzzy_number_match
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.0 | Priority: | normal |
Severity: | normal | Version: | 5.3 |
Component: | Build/Test Tools | Keywords: | has-patch has-unit-tests |
Focuses: | Cc: |
Description
Change History (12)
This ticket was mentioned in PR #1742 on WordPress/wordpress-develop by pbearne.
20 months ago
#1
- Keywords has-patch has-unit-tests added
#2
@
20 months ago
- Milestone changed from Awaiting Review to 5.9
- Version set to 5.3
Thanks for the ticket and patch.
wp_fuzzy_number_match
introduce in 5.3.0
. Let's set the version for the ticket.
Set milestone to 5.9
#4
@
19 months ago
- Milestone changed from 5.9 to 6.0
5.9 is in Feature Freeze and focus is on defects. With less than a week until Beta 1, there's likely not time to in the 5.9 cycle to focus on these tests.
I'm moving it to the next release cycle. As tests can be committed at anytime into trunk
, if someone has the time to get review and get this patch committed, please do so. Else, let's get it done early in 6.0.
#5
@
14 months ago
- Component changed from General to Build/Test Tools
Moving to the Build/Test Tools component.
#6
@
14 months ago
- Keywords needs-refresh added
I have left a review on the PR which suggests changes for:
- Consistency in the test suite.
- Stricter assertions.
- Ensuring that dataset keys show correctly when using the
--testdox
parameter. - More datasets.
Most of these changes are very quick to make and can be landed in 6.0.
Additional datasets will take some thought, so these could be added later if they need more consideration.
@pbearne let us know whether you have time to work on the requested changes.
This ticket was mentioned in PR #2487 on WordPress/wordpress-develop by pbearne.
14 months ago
#8
- Keywords needs-refresh removed
refeshed
Trac ticket: https://core.trac.wordpress.org/ticket/54239
SergeyBiryukov commented on PR #2487:
13 months ago
#12
Thanks for the PR! I have fixed WPCS issues and updated the data provider array keys to be a bit more descriptive.
Trac ticket: https://core.trac.wordpress.org/ticket/54239#ticket