Make WordPress Core

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#54239 closed task (blessed) (fixed)

tests for wp_fuzzy_number_match

Reported by: pbearne's profile pbearne Owned by: hellofromtonya's profile hellofromTonya
Milestone: 6.0 Priority: normal
Severity: normal Version: 5.3
Component: Build/Test Tools Keywords: has-patch has-unit-tests
Focuses: Cc:

Description


Change History (12)

This ticket was mentioned in PR #1742 on WordPress/wordpress-develop by pbearne.


3 years ago
#1

  • Keywords has-patch has-unit-tests added

#2 @mukesh27
3 years ago

  • Milestone changed from Awaiting Review to 5.9
  • Version set to 5.3

Thanks for the ticket and patch.

wp_fuzzy_number_match introduce in 5.3.0. Let's set the version for the ticket.

Set milestone to 5.9

#3 @hellofromTonya
3 years ago

  • Owner set to hellofromTonya
  • Status changed from new to assigned

#4 @hellofromTonya
2 years ago

  • Milestone changed from 5.9 to 6.0

5.9 is in Feature Freeze and focus is on defects. With less than a week until Beta 1, there's likely not time to in the 5.9 cycle to focus on these tests.

I'm moving it to the next release cycle. As tests can be committed at anytime into trunk, if someone has the time to get review and get this patch committed, please do so. Else, let's get it done early in 6.0.

#5 @costdev
2 years ago

  • Component changed from General to Build/Test Tools

Moving to the Build/Test Tools component.

#6 @costdev
2 years ago

  • Keywords needs-refresh added

I have left a review on the PR which suggests changes for:

  • Consistency in the test suite.
  • Stricter assertions.
  • Ensuring that dataset keys show correctly when using the --testdox parameter.
  • More datasets.

Most of these changes are very quick to make and can be landed in 6.0.

Additional datasets will take some thought, so these could be added later if they need more consideration.

@pbearne let us know whether you have time to work on the requested changes.

#7 @pbearne
2 years ago

I am working on this

This ticket was mentioned in PR #2487 on WordPress/wordpress-develop by pbearne.


2 years ago
#8

  • Keywords needs-refresh removed

#9 @pbearne
2 years ago

refreshed
the merge from trunk broke it so I created a new PR

#10 @costdev
2 years ago

  • Type changed from defect (bug) to task (blessed)

#11 @SergeyBiryukov
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 53321:

Tests: Add unit tests for wp_fuzzy_number_match().

Props pbearne, costdev, mukesh27, hellofromTonya, SergeyBiryukov.
Fixes #54239.

SergeyBiryukov commented on PR #2487:


2 years ago
#12

Thanks for the PR! I have fixed WPCS issues and updated the data provider array keys to be a bit more descriptive.

Merged in https://core.trac.wordpress.org/changeset/53321.

Note: See TracTickets for help on using tickets.