#5424 closed defect (bug) (invalid)
wpdb: use function_exists() instead of slower version_compare()
Reported by: | DD32 | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 2.5 |
Component: | Optimization | Keywords: | has-patch |
Focuses: | Cc: |
Description
Wpdb's escaping code currently compares the PHP version to determine if a function will be available or not.
function_exists('mysql_real_escape_string');
is about twice as fast as the current code(on testing of 1,000 iterations):
version_compare( phpversion(), '4.3.0' );
Attachments (1)
Change History (9)
Note: See
TracTickets for help on using
tickets.
That code isn't even be running since we return on the line before. But, yes, function_exists is better for such things.