WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#54273 closed enhancement (wontfix)

Missing third argument force "true" in in_array() in some files

Reported by: yagniksangani's profile yagniksangani Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: External Libraries Keywords: close
Focuses: coding-standards Cc:

Description

There are missing third argument true to force in in_array() function in some files

Attachments (1)

54273.diff​ (17.1 KB) - added by yagniksangani 3 years ago.
Strict Comparison in in_array function

Download all attachments as: .zip

Change History (3)

@yagniksangani
3 years ago

Strict Comparison in in_array function

#1 @mukesh27
3 years ago

  • Component changed from General to External Libraries
  • Keywords close added; needs-patch removed

Thanks for the ticket and the patch!

SimplePie is an external library and should not be patched here, any suggested changes to its files should be submitted upstream: ​https://github.com/simplepie/simplepie.

Sodium Compat is an external library and should not be patched here, any suggested changes to its files should be submitted upstream: ​https://github.com/paragonie/sodium_compat

#2 @SergeyBiryukov
3 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Thanks for the patch! As noted above, these are external libraries and should be patched in their respective projects.

Note: See TracTickets for help on using tickets.