WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#54273 closed enhancement (wontfix)

Missing third argument force "true" in in_array() in some files

Reported by: yagniksangani Owned by:
Priority: normal Milestone:
Component: External Libraries Version:
Severity: normal Keywords: close
Cc: Focuses: coding-standards

Description

There are missing third argument true to force in in_array() function in some files

Attachments (1)

54273.diff​ (17.1 KB ) - added by yagniksangani 5 years ago.
Strict Comparison in in_array function

Download all attachments as: .zip

Change History (3)

@yagniksangani
5 years ago

Strict Comparison in in_array function

#1 @mukesh27
5 years ago

  • Component General → External Libraries
  • Keywords close added; needs-patch removed

Thanks for the ticket and the patch!

SimplePie is an external library and should not be patched here, any suggested changes to its files should be submitted upstream: ​https://github.com/simplepie/simplepie.

Sodium Compat is an external library and should not be patched here, any suggested changes to its files should be submitted upstream: ​https://github.com/paragonie/sodium_compat

#2 @SergeyBiryukov
5 years ago

  • Milestone Awaiting Review
  • Resolution → wontfix
  • Status new → closed

Thanks for the patch! As noted above, these are external libraries and should be patched in their respective projects.

Note: See TracTickets for help on using tickets.