#54275 closed enhancement (fixed)
need to remove some empty html element (span)
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Help/About | Keywords: | has-patch commit |
Focuses: | ui, coding-standards | Cc: |
Description
In credits.php
file during show core contributors there are some empty span
element which is not necessary to generate.
During showing core contribution it's accessing $person_data[3]
without any checking. Not every contributor have title so some cases $person_data[3]
return empty string. In that case, It's not necessary to print empty string into span element.
See the screenshot below to understand it properly.
Attachments (2)
Change History (15)
#2
@
20 months ago
Hi, thanks for spotting this and opening a ticket.
However, while I understand it is not optimal, I'm wondering what is the benefit of this change. The current code is valid and also we can't change the about page of previously released WordPress versions.
#3
follow-up:
↓ 4
@
20 months ago
- Keywords commit added
- Milestone changed from Awaiting Review to 5.9
- Version trunk deleted
Hmm… ok I have to apology because I didn't read your patch before commenting.
The code looks good to me. A nice tiny enhancement. Moving to milestone 5.9
and marking for commit
.
#4
in reply to:
↑ 3
@
20 months ago
Thank you. I was confused about your previous comment. That's why I didn't say anything. Thank you for your apology and double review.
Replying to audrasjb:
Hmm… ok I have to apologize because I didn't read your patch before commenting.
The code looks good to me. A nice tiny enhancement. Moving to milestone5.9
and marking forcommit
.
#5
@
20 months ago
- Type changed from defect (bug) to enhancement
Looks good to me.
Set ticket type to enhancement
.
This ticket was mentioned in PR #1764 on WordPress/wordpress-develop by sayedulsayem.
20 months ago
#6
In credits.php file, during show core contributors there are some empty span element which is not necessary to generate.
During showing core contribution it's accessing $person_data[3] without any checking. Not every contributor has a title so in some cases, $person_data[3] returns an empty string. In that case, It's not necessary to print empty strings into the span element.
See the screenshot below to understand it properly.
Trac ticket: https://core.trac.wordpress.org/ticket/54275
This ticket was mentioned in PR #1766 on WordPress/wordpress-develop by sayedulsayem.
20 months ago
#7
In credits.php file, during show core contributors there are some empty span element which is not necessary to generate.
During showing core contribution it's accessing $person_data[3] without any checking. Not every contributor has a title so in some cases, $person_data[3] returns an empty string. In that case, It's not necessary to print empty strings into the span element.
See the screenshot below to understand it properly.
Trac ticket: core.trac.wordpress.org/ticket/54275
This ticket was mentioned in Slack in #core by abhanonstopnews. View the logs.
20 months ago
#9
follow-up:
↓ 10
@
20 months ago
For committers: just noting the good patch to commit is 54275.diff
as the PR looks wrong. (EDIT: the first PR is closed, the second one is an exact matching of the diff file)
#10
in reply to:
↑ 9
@
20 months ago
There is something wrong with the first PR. That's why I made another one. Can you please look into the second PR?
Replying to audrasjb:
For committers: just noting the good patch to commit is
54275.diff
as the PR looks wrong.
This ticket was mentioned in Slack in #core by sayedulsayem. View the logs.
20 months ago
hellofromtonya commented on PR #1766:
17 months ago
#13
Committed via https://core.trac.wordpress.org/changeset/51920.
patch added