need to remove some empty html element (span)

[sayedulsayem]

In credits.php file during show core contributors there are some empty span element which is not necessary to generate.

During showing core contribution it's accessing $person_data[3] without any checking. Not every contributor have title so some cases $person_data[3] return empty string. In that case, It's not necessary to print empty string into span element.

See the screenshot below to understand it properly.

[sayedulsayem]

patch added

[audrasjb]

Hi, thanks for spotting this and opening a ticket.

However, while I understand it is not optimal, I'm wondering what is the benefit of this change. The current code is valid and also we can't change the about page of previously released WordPress versions.

[audrasjb]

Hmm… ok I have to apology because I didn't read your patch before commenting.
The code looks good to me. A nice tiny enhancement. Moving to milestone 5.9 and marking for commit.

[sayedulsayem]

Thank you. I was confused about your previous comment. That's why I didn't say anything. Thank you for your apology and double review.

Replying to audrasjb:

Hmm… ok I have to apologize because I didn't read your patch before commenting.
The code looks good to me. A nice tiny enhancement. Moving to milestone 5.9 and marking for commit.

[mukesh27]

Looks good to me.

Set ticket type to enhancement.

In credits.php file, during show core contributors there are some empty span element which is not necessary to generate.
During showing core contribution it's accessing $person_data[3] without any checking. Not every contributor has a title so in some cases, $person_data[3] returns an empty string. In that case, It's not necessary to print empty strings into the span element.
See the screenshot below to understand it properly.

Trac ticket: https://core.trac.wordpress.org/ticket/54275

In credits.php file, during show core contributors there are some empty span element which is not necessary to generate.
During showing core contribution it's accessing $person_data[3] without any checking. Not every contributor has a title so in some cases, $person_data[3] returns an empty string. In that case, It's not necessary to print empty strings into the span element.
See the screenshot below to understand it properly.

Trac ticket: core.trac.wordpress.org/ticket/54275

[audrasjb]

For committers: just noting the good patch to commit is 54275.diff as the PR looks wrong. (EDIT: the first PR is closed, the second one is an exact matching of the diff file)

[sayedulsayem]

There is something wrong with the first PR. That's why I made another one. Can you please look into the second PR?
Replying to audrasjb:

For committers: just noting the good patch to commit is 54275.diff as the PR looks wrong.

[SergeyBiryukov]

In 51920:

Help/About: Don't output empty <span> tags on Credits screen.

If the contributor does not have a title, the empty tags are not necessary.

Follow-up to [17877], [17909], [17942], [18162], [19143], [46709].

Props sayedulsayem, audrasjb, mukesh27.
Fixes #54275.

Committed via https://core.trac.wordpress.org/changeset/51920.