Make WordPress Core

Opened 3 years ago

Closed 6 months ago

Last modified 6 months ago

#54276 closed enhancement (fixed)

Grammatical errors in "About" & "Privacy Policy Guide" page

Reported by: sabbirshouvo's profile sabbirshouvo Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.5 Priority: normal
Severity: normal Version:
Component: Text Changes Keywords: has-patch
Focuses: ui-copy Cc:

Description

There are some minor grammatical errors on those two pages. 3 errors to be exact.

Example: to do things like ''create'' a portfolio or a page full of your favorite recipes should be to do things like ''creating'' a portfolio or a page full of your favorite recipes.

I've added patch for the errors. I understand these pages are the least visited ones. But I believe those grammatical mistakes should be fixed.

Attachments (4)

54276.diff (3.0 KB) - added by sabbirshouvo 3 years ago.
54276.2.diff (10.3 KB) - added by sabbirshouvo 3 years ago.
replace "web site" with "website" everywhere except third-party vendor files.
54276.3.diff (11.0 KB) - added by sabbirshouvo 3 years ago.
adding changes for wp-includes/js/colorpicker.js
54276.4.diff (9.8 KB) - added by cafenoirdesign 6 months ago.
Refresh of existing patch

Download all attachments as: .zip

Change History (11)

@sabbirshouvo
3 years ago

#1 @sabernhardt
3 years ago

  • Keywords needs-refresh added

Thanks for the report and patch!

The About page sentence relates to 5.8 releases, so I'm not sure that is worth editing now. (5.8.2 is scheduled for November 10, and 5.9 should be available on December 14.) If someone disagrees with me about that, the change could fit better in another ticket anyway.

The Privacy Policy page includes "web site" as separate words in five places. The other four are in wp-admin\includes\class-wp-privacy-policy-content.php. And the comma is a good addition to the sentence in privacy-policy-guide.php.

(If we want to change "web site" to "website" everywhere, I also found that in 3 PHP docblocks or comments.)

#2 @sabbirshouvo
3 years ago

About the "web site", I'll update the patch containing changes in all locations. I was only checking specific pages that's why I couldn't find them all! I think the website should be a single word!

Technically "Web site" was the original spelling but rarely used while "website" become much more popular.

Last edited 3 years ago by sabbirshouvo (previous) (diff)

@sabbirshouvo
3 years ago

replace "web site" with "website" everywhere except third-party vendor files.

#3 follow-up: @mukesh27
3 years ago

  • Component changed from Privacy to General

Hi there, thanks for the patch!

Not sure but can we replace "web site" with "website" in colorpicker.js as previously core developer change this file commit history

#4 in reply to: ↑ 3 @sabbirshouvo
3 years ago

@mukesh27 I leave that one alone as it's a third-party library. But as you mentioned previously core developers made changes on that file then I can edit and update the patch.

@sabbirshouvo
3 years ago

adding changes for wp-includes/js/colorpicker.js

@cafenoirdesign
6 months ago

Refresh of existing patch

#5 @cafenoirdesign
6 months ago

  • Keywords needs-refresh removed

I've refreshed this ticket to be compatible with the latest version.

#6 @SergeyBiryukov
6 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 57131:

Text Changes: Update mentions of “web site” to “website” for consistency.

While “web site” was the original spelling, this variant has become rarely used, and “website” is now the standard spelling, already used throughout most of the WordPress core.

Reference: Wikipedia: Website.

Props LiamMcArthur, cafenoirdesign, sabbirshouvo, sabernhardt, ironprogrammer, mukesh27.
Fixes #59853, #54276.

#7 @SergeyBiryukov
6 months ago

  • Component changed from General to Text Changes
  • Milestone changed from Awaiting Review to 6.5
Note: See TracTickets for help on using tickets.