WordPress.org

Make WordPress Core

Opened 7 weeks ago

Closed 7 weeks ago

Last modified 6 weeks ago

#54284 closed defect (bug) (fixed)

CSS coding standards issue in the `print_emoji_styles()` function

Reported by: audrasjb Owned by: SergeyBiryukov
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Formatting Keywords: has-patch commit
Focuses: css Cc:

Description

There is an unwanted space in the margin declaration of the styles printed by the print_emoji_styles() function.

Attachments (2)

54284.diff (455 bytes) - added by audrasjb 7 weeks ago.
Coding Standards: Formatting: Remove an unwanted space in the print_emoji_styles() function.
54284.1.diff (457 bytes) - added by audrasjb 7 weeks ago.
Patch refresh

Download all attachments as: .zip

Change History (11)

@audrasjb
7 weeks ago

Coding Standards: Formatting: Remove an unwanted space in the print_emoji_styles() function.

#1 @audrasjb
7 weeks ago

  • Keywords has-patch added; needs-patch removed

In 54284.diff:
Coding Standards: Formatting: Remove an unwanted space in the CSS printed by the print_emoji_styles() function.

#2 @sabernhardt
7 weeks ago

I think the margin is only intended for the sides (it had been 0 .05em 0 .1em before r31786).

However, we still could add the leading zero before the decimal point:
margin: 0 0.07em !important;

#3 @audrasjb
7 weeks ago

  • Keywords needs-refresh added

Hooooo good point, I think I was confused because the leading zero was missing :D
Editing the patch accordingly

@audrasjb
7 weeks ago

Patch refresh

#4 @audrasjb
7 weeks ago

Refreshed in 54284.1.diff

Indeed, the leading zero suggested by WPCS is less confusing :)

#5 @audrasjb
7 weeks ago

  • Keywords needs-refresh removed

#6 @audrasjb
7 weeks ago

New explanation suggestion for the changeset:
Formatting: Coding Standards: Add a leading zero in the CSS declarations printed by the print_emoji_styles() function.

#7 @mukesh27
7 weeks ago

  • Keywords commit added

54284.1.diff patch looks good to me.

Ready to marge, mark as commit.

#8 @SergeyBiryukov
7 weeks ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 51918:

Coding Standards: Add a leading zero in the CSS declarations printed by the print_emoji_styles() function.

Follow-up to [31733], [31786].

Props audrasjb, sabernhardt.
Fixes #54284.

This ticket was mentioned in Slack in #core by sergey. View the logs.


6 weeks ago

Note: See TracTickets for help on using tickets.