#54284 closed defect (bug) (fixed)
CSS coding standards issue in the `print_emoji_styles()` function
Reported by: | audrasjb | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Formatting | Keywords: | has-patch commit |
Focuses: | css | Cc: |
Description
There is an unwanted space in the margin
declaration of the styles printed by the print_emoji_styles()
function.
Attachments (2)
Change History (11)
#1
@
3 years ago
- Keywords has-patch added; needs-patch removed
In 54284.diff
:
Coding Standards: Formatting: Remove an unwanted space in the CSS printed by the print_emoji_styles() function.
#2
@
3 years ago
I think the margin is only intended for the sides (it had been 0 .05em 0 .1em
before r31786).
However, we still could add the leading zero before the decimal point:
margin: 0 0.07em !important;
#3
@
3 years ago
- Keywords needs-refresh added
Hooooo good point, I think I was confused because the leading zero was missing :D
Editing the patch accordingly
#4
@
3 years ago
Refreshed in 54284.1.diff
Indeed, the leading zero suggested by WPCS is less confusing :)
#6
@
3 years ago
New explanation suggestion for the changeset:
Formatting: Coding Standards: Add a leading zero in the CSS declarations printed by the print_emoji_styles()
function.
#7
@
3 years ago
- Keywords commit added
54284.1.diff patch looks good to me.
Ready to marge, mark as commit
.
#8
@
3 years ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 51918:
Coding Standards: Formatting: Remove an unwanted space in the
print_emoji_styles()
function.