Make WordPress Core

Opened 4 years ago

Last modified 5 weeks ago

#54289 reviewing enhancement

Improve get_shortcode_regex performance

Reported by: antek88's profile Antek88 Owned by: flixos90's profile flixos90
Milestone: 6.9 Priority: normal
Severity: normal Version: 5.9
Component: Shortcodes Keywords: has-patch
Focuses: performance Cc:

Description

Hi,

It's my first PR to WordPress, I hope it goes well :).

I ran Blackfire on my homepage (eCommerce shop with Woocommerce plugin). After analyzing it, I see that many shortcodes are parsing, but I don't use it directly. After some investigation, I see that in
get_shortcode_regex is many unnecessary call implode/array_map function for empty $tagsname argument.
After this patch, page response time is reduced by almost ~200ms.
Blackfire profile screen: https://monosnap.com/file/Vq4pXvVggX2AdEG4736sl0cShQNBbk

Change History (2)

#2 @flixos90
5 weeks ago

  • Milestone changed from Awaiting Review to 6.9
  • Owner set to flixos90
  • Status changed from new to reviewing

Thank you for the report @Antek88, and welcome to Trac.

While this may be a valid ticket, I think at this point short codes aren't recommended anymore, so I'd consider this low severity. That said, since you have already opened a pull request, it might be straightforward enough to address. Let me take a look.

Note: See TracTickets for help on using tickets.