Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#54297 closed defect (bug) (duplicate)

Multisite: lostpasswordform always posts to the main-site wp-login.php file

Reported by: henry.wright Owned by:
Priority: normal Milestone:
Component: Login and Registration Version:
Severity: normal Keywords: has-patch
Cc: Focuses: multisite

Description

The lost password form always posts to the main-site wp-login.php file. If the lost password form on a sub-site is being used then I'd expect the form to post to the sub-site wp-login.php file.

Current

<form name="lostpasswordform" id="lostpasswordform" action="<?php echo esc_url( network_site_url( 'wp-login.php?action=lostpassword', 'login_post' ) ); ?>" method="post">

Suggestion

<form name="lostpasswordform" id="lostpasswordform" action="<?php echo esc_url( site_url( 'wp-login.php?action=lostpassword', 'login_post' ) ); ?>" method="post">

Attachments (1)

54297.diff​ (750 bytes ) - added by henry.wright 5 years ago.

Download all attachments as: .zip

Change History (10)

#1 @henry.wright
5 years ago

This is an issue when the sub-site uses a different language to the main-site.

#2 @costdev
5 years ago

  • Resolution → duplicate
  • Status new → closed

Hi @henrywright, this ticket appears to be a duplicate of #21352. Add your thoughts and suggestion to that ticket to help further the discussion on this topic.

#3 @henry.wright
5 years ago

Hi @costdev. Although related, it isn't a duplicate. This ticket refers to the location of the form submission and the #21352 ticket refers to the function to generating the lost password URL.

Version 0, edited 5 years ago by henry.wright (next)

#4 @henry.wright
5 years ago

  • Resolution duplicate
  • Status closed → reopened

#5 @henry.wright
5 years ago

Happy to close this ticket though if you prefer to broaden the scope of the #21352 ticket

#6 @costdev
5 years ago

@henrywright Thanks for clarifying that and correcting me!

Let's see what others think about that. I've updated my comment on that ticket to note that this one is a related ticket, not a duplicate.

@henry.wright
5 years ago

#7 @henry.wright
5 years ago

  • Keywords has-patch added

Attached is 54297.diff. This patch posts to the sub-site wp-login.php file instead of the main-site wp-login.php file.

#8 @ocean90
5 years ago

  • Milestone Awaiting Review
  • Resolution → duplicate
  • Status reopened → closed

Duplicate of #36439.

#9 @henry.wright
5 years ago

Thanks @ocean90

Note: See TracTickets for help on using tickets.