#54318 closed task (blessed) (fixed)
Import Twenty Twenty-Two
Reported by: | jffng | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 5.9 | Priority: | normal |
Severity: | normal | Version: | 5.9 |
Component: | Bundled Theme | Keywords: | has-patch dev-reviewed commit fixed-major |
Focuses: | Cc: |
Description
The default theme for 2022 should be added to trunk/wp-content/themes
in time for the feature freeze on November 9.
Change History (83)
This ticket was mentioned in Slack in #core by jffng. View the logs.
2 years ago
#2
@
2 years ago
- Component changed from Themes to Bundled Theme
- Milestone changed from Awaiting Review to 5.9
- Summary changed from Add the default theme for Twenty Twenty-Two to Import Twenty Twenty-Two
- Type changed from feature request to task (blessed)
This ticket was mentioned in PR #1817 on WordPress/wordpress-develop by jffng.
2 years ago
#4
- Keywords has-patch added; needs-patch removed
Trac ticket: https://core.trac.wordpress.org/ticket/54318#ticket
2 years ago
#5
In the past discussions and iterations happen on Core merge PRs and are then copied upstream into the theme repository to keep the two in sync. We'll follow the same process here.
Sounds good to me, thank you for the review @desrosj ! I believe the feedback has been addressed, let me know what you think.
#10
@
2 years ago
@poena It was not! I probably missed it because there are some rules that ignore asset
directories, and my svn add
command skipped it.
This was fixed in [52107] (I had the incorrect ticket number there), and I rebuilt the nightly. So updating to the latest should fix this.
#11
follow-up:
↓ 12
@
2 years ago
With the assets folder included, I am getting the following 404 in the editors and front:
10:01:18.141 localhost/:161 GET http://localhost:8889/wp-content/themes/twentytwentytwo/assets/fonts/SourceSerif4Variable-Roman.ttf.woff2/ net::ERR_ABORTED 404 (Not Found)
#12
in reply to:
↑ 11
@
2 years ago
Replying to poena:
With the assets folder included, I am getting the following 404 in the editors and front:
10:01:18.141 localhost/:161 GET http://localhost:8889/wp-content/themes/twentytwentytwo/assets/fonts/SourceSerif4Variable-Roman.ttf.woff2/ net::ERR_ABORTED 404 (Not Found)
I'm not getting a 404 on the font using trunk myself (tested on Safari, Chrome and FF)
This ticket was mentioned in PR #1885 on WordPress/wordpress-develop by jffng.
2 years ago
#14
Trac ticket: https://core.trac.wordpress.org/ticket/54318
#16
in reply to:
↑ 13
@
2 years ago
Since the theme has been imported in [52081] and [52107], does it make sense to close this and address specific issues in follow up tickets?
Whichever works for you and the team's workflows. Having one ongoing task ticket to use for syncing the theme from GitHub until the RC phase is how it's been done the last few default themes. But whenever the theme is at a solid and stable state (or when you prefer), this can be closed out in favor of specific tickets going forward. It's probably good to archive the GH repo at that time, and move all of the open issues over to Trac.
This ticket was mentioned in PR #1906 on WordPress/wordpress-develop by jffng.
2 years ago
#18
Trac ticket: https://core.trac.wordpress.org/ticket/54318
2 years ago
#19
We should be sure to integrate this fix before merge — otherwise the header template errors out:
https://github.com/WordPress/twentytwentytwo/pull/247
This ticket was mentioned in Slack in #core-themes by jffng. View the logs.
2 years ago
2 years ago
#22
Committed in https://core.trac.wordpress.org/changeset/52081.
This ticket was mentioned in PR #1970 on WordPress/wordpress-develop by jffng.
2 years ago
#23
Trac ticket: https://core.trac.wordpress.org/ticket/54318
The PR includes the following changes from the Twenty Twenty-One GitHub repo: https://github.com/WordPress/twentytwentytwo/compare/fc07d3974c0a7b41405b7b739dace2fbb3b3605f...1a121e0224c75ffa1c34fff4860386e9cdb9e3bd
2 years ago
#24
Committed in https://core.trac.wordpress.org/changeset/52222
This ticket was mentioned in Slack in #core by jffng. View the logs.
2 years ago
2 years ago
#28
Committed in https://core.trac.wordpress.org/changeset/52283.
#29
@
2 years ago
- Keywords needs-testing has-patch commit removed
Resetting keywords as latest sync updates were committed in [52283].
This ticket was mentioned in PR #2017 on WordPress/wordpress-develop by jffng.
2 years ago
#31
- Keywords has-patch added
Syncs the following changeset for the default theme to trunk
: https://github.com/WordPress/twentytwentytwo/compare/1a121e0224c75ffa1c34fff4860386e9cdb9e3bd...da994d1fe50c016cd11ecf33da7de33f652184e4
Trac ticket: https://core.trac.wordpress.org/ticket/54318
2 years ago
#33
Thanks for the quick review @hellofromtonya , closed in https://core.trac.wordpress.org/changeset/52335.
This ticket was mentioned in PR #2051 on WordPress/wordpress-develop by jffng.
2 years ago
#34
Trac ticket: [](https://core.trac.wordpress.org/ticket/54318#ticket)
This ticket was mentioned in PR #2052 on WordPress/wordpress-develop by jffng.
2 years ago
#35
Trac ticket: https://core.trac.wordpress.org/ticket/54318#ticket
The matching list of changes in the development repository can be found here: https://github.com/WordPress/twentytwentytwo/compare/da994d1fe50c016cd11ecf33da7de33f652184e4...88a8f2e3b4c6653e2deb5c29ae0b7e42b1f99433
2 years ago
#38
Committed in https://core.trac.wordpress.org/changeset/52375
This ticket was mentioned in PR #2066 on WordPress/wordpress-develop by jffng.
2 years ago
#39
Bug fixes and improvements for TT2. Changeset from the development repo: https://github.com/WordPress/twentytwentytwo/compare/623a4d798227a5eb948d0286d3fa779383997649...d6cb56cce4d4789965d05327ec54e48a1be4a171 cc @kjellr
Trac ticket: https://core.trac.wordpress.org/ticket/54318
2 years ago
#40
This is working well in my testing. 👍
This comments issue is pretty glaring, but it's tracked already:
We should be sure this is fixed before release.
#44
@
2 years ago
- Keywords has-patch commit removed
Resetting keywords as all work has been committed.
This ticket was mentioned in PR #2105 on WordPress/wordpress-develop by kjellr.
2 years ago
#45
- Keywords has-patch added
Bug fixes and improvements for TT2. Changeset from the development repo: https://github.com/WordPress/twentytwentytwo/compare/d6cb56cce4d4789965d05327ec54e48a1be4a171...8564fd281f453c52a1b5bf681e55bd720c0da709 cc @jffng
This PR also deletes three unused files. These were removed from the dev repo, but never removed from core:
src/wp-content/themes/twentytwentytwo/assets/images/bird-on-salmon-alt-crop.jpg
(removed in https://github.com/WordPress/twentytwentytwo/pull/252)src/wp-content/themes/twentytwentytwo/inc/patterns/footer-title-tagline-social-dark.php
(removed in https://github.com/WordPress/twentytwentytwo/pull/258)src/wp-content/themes/twentytwentytwo/inc/patterns/page-about-big-image-and-buttons.php
(removed in https://github.com/WordPress/twentytwentytwo/pull/258)
Trac ticket: https://core.trac.wordpress.org/ticket/54318
2 years ago
#47
Committed in https://core.trac.wordpress.org/changeset/52430
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
2 years ago
#49
@
2 years ago
- Resolution set to fixed
- Status changed from assigned to closed
With the last synchronization for RC1, let's close this as fixed, and reopen if needed for RC2.
This ticket was mentioned in PR #2132 on WordPress/wordpress-develop by jffng.
2 years ago
#50
Syncs the following changeset from the theme's development repo to core: https://github.com/WordPress/twentytwentytwo/compare/8564fd281f453c52a1b5bf681e55bd720c0da709...f0346e1ad24b6dd5fe37b7d82bd88b0e9e3fdf22
Trac ticket: https://core.trac.wordpress.org/ticket/54318
cc @kjellr
#51
@
2 years ago
- Keywords dev-feedback added
- Resolution fixed deleted
- Status changed from closed to reopened
#52
@
2 years ago
- Keywords commit dev-reviewed added; dev-feedback removed
Marking for backport to 5.9 branch for RC2.
#55
@
2 years ago
- Keywords has-patch commit dev-reviewed removed
Resetting keywords as commit and backport are done.
#56
@
2 years ago
- Resolution set to fixed
- Status changed from reopened to closed
Closing for RC2. Reopen if necessary for resync of other RC releases.
2 years ago
#57
Committed to trunk in https://core.trac.wordpress.org/changeset/52555 and backported in https://core.trac.wordpress.org/changeset/52557
This ticket was mentioned in PR #2183 on WordPress/wordpress-develop by jffng.
2 years ago
#58
- Keywords has-patch added
#59
@
2 years ago
- Keywords dev-feedback added
- Resolution fixed deleted
- Status changed from closed to reopened
#60
@
2 years ago
- Keywords dev-reviewed added; dev-feedback removed
@jffng thanks for the update. The proposed changeset looks good to go 👍
2 years ago
#63
Committed in https://core.trac.wordpress.org/changeset/52589.
#65
@
2 years ago
- Owner set to audrasjb
- Resolution set to fixed
- Status changed from reopened to closed
In 52590:
This ticket was mentioned in PR #2203 on WordPress/wordpress-develop by jffng.
2 years ago
#66
Since the 5.9 dry run and code freeze are on Monday morning (11a EST), this PR updates the required version for the theme to 5.9.
Trac ticket: https://core.trac.wordpress.org/ticket/54318
#67
@
2 years ago
- Keywords dev-feedback added
- Resolution fixed deleted
- Status changed from closed to reopened
This ticket was mentioned in PR #2205 on WordPress/wordpress-develop by desrosj.
2 years ago
#74
- Keywords has-unit-tests added
This allows the minimum version of WordPress required for Twenty Twenty-Two to be set to 5.9 prior to 5.9 actually being released.
Trac ticket: https://core.trac.wordpress.org/ticket/54318
#75
@
2 years ago
- Keywords has-unit-tests removed
- Resolution fixed deleted
- Status changed from closed to reopened
There are some theme tests that are failing in the 5.9 branch after [52614] due to the version in that branch being less than 5.9.
Opened a PR to temporarily add expected exceptions to the test methods encountering this. After the version is bumped to 5.9 and the release is complete, these should be removed.
#76
@
2 years ago
Approved the temporary workaround PR for the 5.9 branch test. Okay to merge to 5.9-branch.
hellofromtonya commented on PR #2205:
2 years ago
#78
Committed via https://core.trac.wordpress.org/changeset/52617.
2 years ago
#80
Committed in https://core.trac.wordpress.org/changeset/52612.
#81
in reply to:
↑ 79
;
follow-up:
↓ 82
@
2 years ago
Replying to hellofromTonya:
What about the version number in the
package.json
file?
Which package.json are you referring to? The one from TT2s development repo is not copied to core.
#82
in reply to:
↑ 81
@
2 years ago
- Resolution set to fixed
- Status changed from reopened to closed
Replying to jffng:
Replying to hellofromTonya:
What about the version number in the
package.json
file?
Which package.json are you referring to? The one from TT2s development repo is not copied to core.
Sorry, Jeff, my comment should have been an issue opened in the TT2 repo along with a PR to update it there.
Re-closing this ticket as latest patches are now committed.
Since 2022 is a block theme, will the checks for Gutenberg need to be removed? [51193]
If so, should we open a separate ticket for that?