Make WordPress Core

Opened 20 months ago

Closed 17 months ago

Last modified 17 months ago

#54318 closed task (blessed) (fixed)

Import Twenty Twenty-Two

Reported by: jffng's profile jffng Owned by: audrasjb's profile audrasjb
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.9
Component: Bundled Theme Keywords: has-patch dev-reviewed commit fixed-major
Focuses: Cc:

Description

The default theme for 2022 should be added to trunk/wp-content/themes in time for the feature freeze on November 9.

Change History (83)

This ticket was mentioned in Slack in #core by jffng. View the logs.


20 months ago

#2 @SergeyBiryukov
20 months ago

  • Component changed from Themes to Bundled Theme
  • Milestone changed from Awaiting Review to 5.9
  • Summary changed from Add the default theme for Twenty Twenty-Two to Import Twenty Twenty-Two
  • Type changed from feature request to task (blessed)

#3 @jffng
19 months ago

Since 2022 is a block theme, will the checks for Gutenberg need to be removed? [51193]

If so, should we open a separate ticket for that?

Last edited 19 months ago by SergeyBiryukov (previous) (diff)

This ticket was mentioned in PR #1817 on WordPress/wordpress-develop by jffng.


19 months ago
#4

  • Keywords has-patch added; needs-patch removed

jffng commented on PR #1817:


19 months ago
#5

In the past discussions and iterations happen on Core merge PRs and are then copied upstream into the theme repository to keep the two in sync. We'll follow the same process here.

Sounds good to me, thank you for the review @desrosj ! I believe the feedback has been addressed, let me know what you think.

#6 @desrosj
19 months ago

  • Owner set to desrosj
  • Status changed from new to assigned

#7 @desrosj
19 months ago

In 52081:

Bundled Themes: Import Twenty Twenty-Two, the new default theme for WordPress 5.9.

Twenty Twenty-Two arrives during an exciting time for WordPress themes. With the advent of Full Site Editing and Global Styles, themes are changing structurally and functionally to enable far more avenues for customization than users have come to expect in the past.

To take advantage of these new abilities, Twenty Twenty-Two has been designed to be the most flexible default theme ever created for WordPress.

Props sourav926, aristath, audrasjb, bgardner, briceduclos, poena, colorful-tones, dgwyer, dimadin, gregrickaby, ellenbauer, jffng, kafleg, karmatosed, kraftbj, kjellr, littlebigthing, onemaggie, matveb, mburridge, mtoensing, nickcernis, nielslange, williampatton, pgking, ribaricplusplus, scruffian, soean, utz119, youknowriad, desrosj, richtabor.
See #54318.

#8 @desrosj
19 months ago

In 52093:

Themes: Twenty Twenty-Two is now the default theme.

It's Friday night, and I feel alright. The party is here in the block theme.

See #54318.

#9 @poena
19 months ago

Was the assets folder purposely left out?

#10 @desrosj
19 months ago

@poena It was not! I probably missed it because there are some rules that ignore asset directories, and my svn add command skipped it.

This was fixed in [52107] (I had the incorrect ticket number there), and I rebuilt the nightly. So updating to the latest should fix this.

#11 follow-up: @poena
19 months ago

With the assets folder included, I am getting the following 404 in the editors and front:

10:01:18.141 localhost/:161 GET http://localhost:8889/wp-content/themes/twentytwentytwo/assets/fonts/SourceSerif4Variable-Roman.ttf.woff2/ net::ERR_ABORTED 404 (Not Found)

#12 in reply to: ↑ 11 @onemaggie
19 months ago

Replying to poena:

With the assets folder included, I am getting the following 404 in the editors and front:

10:01:18.141 localhost/:161 GET http://localhost:8889/wp-content/themes/twentytwentytwo/assets/fonts/SourceSerif4Variable-Roman.ttf.woff2/ net::ERR_ABORTED 404 (Not Found)

I'm not getting a 404 on the font using trunk myself (tested on Safari, Chrome and FF)

#13 follow-up: @jffng
19 months ago

Same, the fonts are loading without error for me. Thanks for taking care of the import @desrosj.

Since the theme has been imported in [52081] and [52107], does it make sense to close this and address specific issues in follow up tickets?

#15 @jffng
19 months ago

In 52164:

Twenty Twenty-Two: Import the latest changes from GitHub.

Updates theme.json to use v2 shape, adds styles to search and file block as well as generic text decoration. Fixes a bug in the layout of a query block pattern.

This is a follow-up to [52081]. These changes are ongoing and development continues on GitHub. To view all of the changes included in this commit, see GitHub: https://github.com/WordPress/twentytwentytwo/compare/99db6063beb87eda7f58c3983992d94cd756d9c2...a11fb4932a0f79dc2668e92f118fd315256be9d9

Props desrosj, kjellr, poena.
See #54318.

#16 in reply to: ↑ 13 @desrosj
19 months ago

Since the theme has been imported in [52081] and [52107], does it make sense to close this and address specific issues in follow up tickets?

Whichever works for you and the team's workflows. Having one ongoing task ticket to use for syncing the theme from GitHub until the RC phase is how it's been done the last few default themes. But whenever the theme is at a solid and stable state (or when you prefer), this can be closed out in favor of specific tickets going forward. It's probably good to archive the GH repo at that time, and move all of the open issues over to Trac.

#17 @desrosj
19 months ago

  • Owner desrosj deleted

kjellr commented on PR #1906:


19 months ago
#19

We should be sure to integrate this fix before merge — otherwise the header template errors out:

https://github.com/WordPress/twentytwentytwo/pull/247

#20 @jffng
19 months ago

In 52222:

Twenty Twenty-Two: Sync updates from GitHub.

This commit syncs several changes for the default theme from its active development repository to core.

This is a follow up to [52081], [52107], and [52164]. It includes improvements to the home page template, adding a filter for block patterns, pre-loading the web font, improvements and bug fixes to block patterns, and more. For a full list of changes, visit https://github.com/WordPress/twentytwentytwo/compare/e4f69d0b7ed93f73b33c5991430618d01b0e3cac...25d74deaa57ba49b5a64a8569e6dd9ebadbfb23c.

Props jeffpaul, richtabor, netweb, luminuu, melchoyce, beafealho, clucasrowlands, desrosj, flixos90, joen, otto42, saju4wordpress, westonruter, kjellr, poena.
See #54318.

This ticket was mentioned in Slack in #core-themes by jffng. View the logs.


19 months ago

This ticket was mentioned in Slack in #core by jffng. View the logs.


18 months ago

#26 @hellofromTonya
18 months ago

  • Keywords commit added

Marking PR 1970 ready for commit.

#27 @jffng
18 months ago

In 52283:

Twenty Twenty-Two: Sync updates from GitHub.

This commit syncs minor changes for the default theme from its active development repository to core.

This is a follow up to [52081], [52107], [52164], and [52222]. It includes changes to template part markup, theme.json appearance flags, navigation block markup, and text domains. For a full set of changes, visit https://github.com/WordPress/twentytwentytwo/compare/742df6cb2b01bedfb9ff54210a7b23765baa0d2f...1a121e0224c75ffa1c34fff4860386e9cdb9e3bd.

Props poena, kjellr, onemaggie, hellofromtonya.
See #54318.

#29 @hellofromTonya
18 months ago

  • Keywords needs-testing has-patch commit removed

Resetting keywords as latest sync updates were committed in [52283].

#32 @jffng
18 months ago

In 52335:

Twenty Twenty-Two: Sync updates from GitHub.

This commit syncs minor changes for the default theme from its active development repository to core.

This is a follow up to [52081], [52107], [52164], [52222], and [52283]. It reduces the size of a video asset, renames the templates and template parts directories, and adds CSS for button hover states. To view the full set of changes, visit https://github.com/WordPress/twentytwentytwo/compare/1a121e0224c75ffa1c34fff4860386e9cdb9e3bd...da994d1fe50c016cd11ecf33da7de33f652184e4.

Props kjellr, mburridge, sabernhardt, hellofromtonya, scruffian.
See #54318.

jffng commented on PR #2017:


18 months ago
#33

Thanks for the quick review @hellofromtonya , closed in https://core.trac.wordpress.org/changeset/52335.

jffng commented on PR #2052:


18 months ago
#36

cc @kjellr

#37 @jffng
18 months ago

In 52375:

Twenty Twenty-Two: Sync updates from GitHub for Beta 3.

This commit syncs minor changes for the default theme from its active development repository to core.

This is a follow up to [52081], [52107], [52164], [52222], [52283], and [52335]. The two main changes introduce global padding to site content while still allowing content to be full-width, and re-organize block patterns into Core's existing categories.

To view the full set of changes, visit https://github.com/WordPress/twentytwentytwo/compare/da994d1fe50c016cd11ecf33da7de33f652184e4...88a8f2e3b4c6653e2deb5c29ae0b7e42b1f99433.

Props onemaggie, joen, youknowriad, scruffian, sabernhardt, kjellr.
See #54318.

kjellr commented on PR #2066:


18 months ago
#40

This is working well in my testing. 👍

This comments issue is pretty glaring, but it's tracked already:

https://i0.wp.com/user-images.githubusercontent.com/1202812/146591370-4543411e-a285-4945-a9a4-b383ebb00da9.png

We should be sure this is fixed before release.

#41 @hellofromTonya
18 months ago

  • Keywords commit added

Marking PR 2066 for commit.

#42 @jffng
18 months ago

In 52392:

Twenty Twenty-Two: Sync updates from GitHub for Beta 4.

This commit syncs changes for the default theme from its active development repository to core.

This is a follow up to [52081], [52107], [52164], [52222], [52283], [52335], and [52375]. It updates the theme's font size presets and fixes an issue with query padding.

To view the full set of changes, visit https://github.com/WordPress/twentytwentytwo/compare/623a4d798227a5eb948d0286d3fa779383997649...d6cb56cce4d4789965d05327ec54e48a1be4a171.

Props schlessera, williampatton, hellofromtonya, kjellr.
See #54318.

jffng commented on PR #2066:


18 months ago
#43

Commited in 52392.

#44 @hellofromTonya
18 months ago

  • Keywords has-patch commit removed

Resetting keywords as all work has been committed.

This ticket was mentioned in PR #2105 on WordPress/wordpress-develop by kjellr.


17 months ago
#45

  • Keywords has-patch added

Bug fixes and improvements for TT2. Changeset from the development repo: https://github.com/WordPress/twentytwentytwo/compare/d6cb56cce4d4789965d05327ec54e48a1be4a171...8564fd281f453c52a1b5bf681e55bd720c0da709 cc @jffng

This PR also deletes three unused files. These were removed from the dev repo, but never removed from core:

Trac ticket: https://core.trac.wordpress.org/ticket/54318

#46 @audrasjb
17 months ago

In 52430:

Twenty Twenty-Two: Sync updates from GitHub for RC 1.

This commit syncs changes for the default theme from its active development repository to core.

This is a follow up to [52081], [52107], [52164], [52222], [52283], [52335], [52375], and [52392].

To view the full set of changes, visit https://github.com/WordPress/twentytwentytwo/compare/2ce387178fd74986099db02cfe590daf53f80de8...8564fd281f453c52a1b5bf681e55bd720c0da709.

This changeset also deletes three unused files. These were removed from the dev repo, but never removed from core.

Props richtabor, kjellr.
See #54318.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


17 months ago

#49 @audrasjb
17 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

With the last synchronization for RC1, let's close this as fixed, and reopen if needed for RC2.

#51 @jffng
17 months ago

  • Keywords dev-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#52 @hellofromTonya
17 months ago

  • Keywords commit dev-reviewed added; dev-feedback removed

Marking for backport to 5.9 branch for RC2.

#53 @desrosj
17 months ago

[52555] merged the latest changes into trunk.

#54 @desrosj
17 months ago

In 52557:

Twenty Twenty-Two: Sync updates from GitHub for RC 2.

This commit syncs changes for the default theme from its active development repository to core.

This is a follow up to [52081], [52107], [52164], [52222], [52283], [52335], [52375], [52392], and [52430]. It includes fixes to the theme's spacing and adds a search template.

To view the full set of changes, visit https://github.com/WordPress/twentytwentytwo/compare/8564fd281f453c52a1b5bf681e55bd720c0da709...f0346e1ad24b6dd5fe37b7d82bd88b0e9e3fdf22.

Props richtabor, kjellr, danieldudzic, scruffian, jffng.
Merges [52555] to the 5.9 branch.
See #54318.

#55 @hellofromTonya
17 months ago

  • Keywords has-patch commit dev-reviewed removed

Resetting keywords as commit and backport are done.

#56 @hellofromTonya
17 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Closing for RC2. Reopen if necessary for resync of other RC releases.

#59 @jffng
17 months ago

  • Keywords dev-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#60 @audrasjb
17 months ago

  • Keywords dev-reviewed added; dev-feedback removed

@jffng thanks for the update. The proposed changeset looks good to go 👍

#61 @audrasjb
17 months ago

  • Keywords commit added

#62 @jffng
17 months ago

In 52589:

Twenty Twenty-Two: Sync updates from GitHub from RC3.

This commit syncs minor changes for the default theme from its active development repository to core.

This is a follow up to [52081], [52107], [52164], [52222], [52283], [52335], [52375], [52392], [52430], and [52555]. It includes fixes to the group, cover, and template part block padding and removes unnecessary group block wrappers from many patterns.

To view the full set of changes, visit https://github.com/WordPress/twentytwentytwo/compare/69d5c512c614bb282d4e4641c19754da2cadb406...91f8748566b8d2d0f7ba5f7552affc0178b9f85b.

Props kjellr, richtabor, audrasjb.
See #54318.

#64 @audrasjb
17 months ago

  • Keywords fixed-major added

#65 @audrasjb
17 months ago

  • Owner set to audrasjb
  • Resolution set to fixed
  • Status changed from reopened to closed

In 52590:

Twenty Twenty-Two: Sync updates from GitHub from RC3.

This commit syncs minor changes for the default theme from its active development repository to core.

This is a follow up to [52081], [52107], [52164], [52222], [52283], [52335], [52375], [52392], [52430], and [52555]. It includes fixes to the group, cover, and template part block padding and removes unnecessary group block wrappers from many patterns.

To view the full set of changes, visit https://github.com/WordPress/twentytwentytwo/compare/69d5c512c614bb282d4e4641c19754da2cadb406...91f8748566b8d2d0f7ba5f7552affc0178b9f85b.

Props kjellr, richtabor, audrasjb, jffng.
Merges [52589] to the 5.9 branch.
Fixes #54318.

This ticket was mentioned in PR #2203 on WordPress/wordpress-develop by jffng.


17 months ago
#66

Since the 5.9 dry run and code freeze are on Monday morning (11a EST), this PR updates the required version for the theme to 5.9.

Trac ticket: https://core.trac.wordpress.org/ticket/54318

#67 @jffng
17 months ago

  • Keywords dev-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#68 @hellofromTonya
17 months ago

PR 2203 is ready for commit.

#69 @jffng
17 months ago

In 52612:

Twenty Twenty-Two: update the required version.

This commit updates the required WordPress version of the 2022 default theme to 5.9 in advance of its release on January 25.

Props hellofromtonya, kjellr, desrosj.
See #54318.

#70 @hellofromTonya
17 months ago

[52612] is good for backport to 5.9-branch.

#71 @desrosj
17 months ago

In 52613:

Twenty Twenty-Two: Re-add the link to the theme’s HelpHub changelog.

See #54318.

#72 @desrosj
17 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 52614:

Twenty Twenty-Two: update the required version.

This commit updates the required WordPress version of the 2022 default theme to 5.9 in advance of its release on January 25.

Props hellofromtonya, kjellr, desrosj.
Merges [52612] and [52613] to the 5.9 branch.
Fixes #54318.

#73 @hellofromTonya
17 months ago

  • Keywords dev-feedback removed

This ticket was mentioned in PR #2205 on WordPress/wordpress-develop by desrosj.


17 months ago
#74

  • Keywords has-unit-tests added

This allows the minimum version of WordPress required for Twenty Twenty-Two to be set to 5.9 prior to 5.9 actually being released.

Trac ticket: https://core.trac.wordpress.org/ticket/54318

#75 @desrosj
17 months ago

  • Keywords has-unit-tests removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

There are some theme tests that are failing in the 5.9 branch after [52614] due to the version in that branch being less than 5.9.

Opened a PR to temporarily add expected exceptions to the test methods encountering this. After the version is bumped to 5.9 and the release is complete, these should be removed.

#76 @hellofromTonya
17 months ago

Approved the temporary workaround PR for the 5.9 branch test. Okay to merge to 5.9-branch.

#77 @desrosj
17 months ago

In 52617:

Tests: Temporarily add expected exceptions to a few theme tests.

These tests are failing after [52614], which raised the minimum version of WordPress required for Twenty Twenty-Two. Since the value of $wp_version is still less than 5.9, these are failing.

After $wp_version is officially bumped to 5.9, these should be removed.

Props hellofromTonya, Clorith.
See #54318.

#79 follow-up: @hellofromTonya
17 months ago

What about the version number in the package.json file?

#81 in reply to: ↑ 79 ; follow-up: @jffng
17 months ago

Replying to hellofromTonya:

What about the version number in the package.json file?

Which package.json are you referring to? The one from TT2s development repo is not copied to core.

#82 in reply to: ↑ 81 @hellofromTonya
17 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Replying to jffng:

Replying to hellofromTonya:

What about the version number in the package.json file?

Which package.json are you referring to? The one from TT2s development repo is not copied to core.

Sorry, Jeff, my comment should have been an issue opened in the TT2 repo along with a PR to update it there.

Re-closing this ticket as latest patches are now committed.

#83 @ocean90
17 months ago

In 52630:

Tests: Revert [52617].

Following [52629], the tests no longer throw an exception.

See #54318.
See #54882.

Note: See TracTickets for help on using tickets.