WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Last modified 4 months ago

#54359 new enhancement

test for wp_get_direct_update_https_url

Reported by: pbearne Owned by:
Priority: normal Milestone: Future Release
Component: General Version:
Severity: normal Keywords: has-patch has-unit-tests
Cc: Focuses: tests

Description

just yet another test

Change History (5)

This ticket was mentioned in ​PR #1795 on ​WordPress/wordpress-develop by ​pbearne.
5 years ago #1

  • Keywords has-patch has-unit-tests added

Trac ticket: https://core.trac.wordpress.org/ticket/54359

​joyously commented on ​PR #1795:
5 years ago #2

This does not test the case for when the environment variable is not set.
Since the function is supposed to return a URL, and it can return an empty string, it seems like that is beyond the unit test (for what happens with an empty URL), but at least it should assert that there is no URL in that case.

​pbearne commented on ​PR #1795:
5 years ago #3

added a test to cover empty state

#4 @desrosj
2 years ago

  • Component Build/Test Tools → General
  • Milestone Awaiting Review → Future Release
  • Type defect (bug) → enhancement

Since this is about adding tests and not a general build or test tooling change, I'm reassigning it to the relevant component.

#5 @desrosj
4 months ago

  • Focuses tests added

Adding the tests focus, which is used to indicate a ticket is solely focused on adding tests.

Note: See TracTickets for help on using tickets.