WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Last modified 2 months ago

#54359 new enhancement

test for wp_get_direct_update_https_url

Reported by: pbearne's profile pbearne Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch has-unit-tests
Focuses: Cc:

Description

just yet another test

Change History (4)

This ticket was mentioned in ​PR #1795 on ​WordPress/wordpress-develop by ​pbearne.
3 years ago #1

  • Keywords has-patch has-unit-tests added

Trac ticket: https://core.trac.wordpress.org/ticket/54359

​joyously commented on ​PR #1795:
3 years ago #2

This does not test the case for when the environment variable is not set.
Since the function is supposed to return a URL, and it can return an empty string, it seems like that is beyond the unit test (for what happens with an empty URL), but at least it should assert that there is no URL in that case.

​pbearne commented on ​PR #1795:
3 years ago #3

added a test to cover empty state

#4 @desrosj
2 months ago

  • Component changed from Build/Test Tools to General
  • Milestone changed from Awaiting Review to Future Release
  • Type changed from defect (bug) to enhancement

Since this is about adding tests and not a general build or test tooling change, I'm reassigning it to the relevant component.

Note: See TracTickets for help on using tickets.