Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#54366 closed task (blessed) (fixed)

Remove temporary Full Site Editing fail safes

Reported by: desrosj's profile desrosj Owned by: desrosj's profile desrosj
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.8
Component: Themes Keywords: has-patch
Focuses: Cc:

Description

In #53410, some checks were added in 5.8 to prevent a user from activating a Full Site Editing enabled theme when the Gutenberg plugin was not active. This helped to prevent the front end of their website from breaking.

These checks (added in [51193] and [51197]) were only meant to be temporary. Now that the remaining parts of the block editor required for Full Site Editing are being merged into Core for 5.9, these checks can be removed.

Attachments (1)

54366.diff (2.2 KB) - added by desrosj 2 years ago.

Download all attachments as: .zip

Change History (8)

@desrosj
2 years ago

#1 @desrosj
2 years ago

  • Summary changed from Remove Full Site Editing fail safes to Remove temporary Full Site Editing fail safes

#2 @poena
2 years ago

This would also close #54342, correct?

Last edited 2 years ago by SergeyBiryukov (previous) (diff)

#3 @desrosj
2 years ago

@poena Ah yes, they are duplicates! Thanks, I missed that one. I'll close that one out since there's a patch here.

#4 @desrosj
2 years ago

#54342 was marked as a duplicate.

#5 @poena
2 years ago

I tested the patch by activating a full site editing theme. The theme was activated without warnings.
(for those testing, full site editing themes are not yet functional, the site will be blank)

#6 @desrosj
2 years ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 52044:

Themes: Remove temporary Full Site Editing safety checks.

These checks were added in [51193] and [51197] as a temporary measure to prevent a site owner from activating a Full Site Editing theme when Gutenberg plugin was not active.

Because Core only had partial support for the features required for FSE, the front end of the site would display a white screen or error message to visitors. Unless the site owner visited the front end, there would be no indication that there was a problem.

Since 5.9 will include the remaining features required for FSE, these checks can be removed.

Props poena, jffng.
Fixes #54366. See #534190.

#7 @desrosj
2 years ago

Even though the other features are not yet committed to Core, I've gone ahead and made this change because it's blocking Twenty Twenty-Two from being merged.

Note: See TracTickets for help on using tickets.