Changes between Initial Version and Version 1 of Ticket #54370, comment 22
- Timestamp:
- 11/12/2021 03:06:27 PM (2 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #54370, comment 22
initial v1 9 9 Therefore this ticket, IMO, is not just duplicating a feature, but instead a new implementation for a new context of this site icon feature. I believe that to make the most of it we should implement it keeping in mind how to turn this later in whatever Gutenberg will need for its settings panel, so maybe a REST site icon thing is good to have. 10 10 11 Given the above, this would be more worth it if - and I doubt it - these admin settings forms will not be later superse eded by Site Editor settings panels and other related functionality. Otherwise it is a temporary solution **in terms of usefulness**, with ''potentially'' a lot of stuff required to be crammed in.11 Given the above, this would be more worth it if - and I doubt it - these admin settings forms will not be later superseded by Site Editor settings panels and other related functionality. Otherwise it is a temporary solution **in terms of usefulness**, with ''potentially'' a lot of stuff required to be crammed in. 12 12 13 I agree with @jameskoster 's view that we shoul tnot ''remove'' settings because the site editor can set them. But to duplicate settings because the site editor can't set them ''yet'' is a different thing in my mind.13 I agree with @jameskoster 's view that we should not ''remove'' settings because the site editor can set them. But to duplicate settings because the site editor can't set them ''yet'' is a different thing in my mind.