Make WordPress Core

Opened 17 years ago

Closed 17 years ago

#5438 closed defect (bug) (fixed)

Upgrade inconsistently directs user

Reported by: pishmishy's profile pishmishy Owned by: pishmishy's profile pishmishy
Milestone: Priority: low
Severity: minor Version: 2.3.1
Component: General Keywords: has-patch upgrade
Focuses: Cc:

Description

Discovered whilst upgrading through a list of links to the upgrade scripts of multiple blogs..

If an upgrade is not necessary then the user is directed onwards to

get_option('home')

If an upgrade has been successfully completed the user is directed onwards to

wp_get_referer()

In the second case, that redirected me back to my list when I was expecting to continue onto my upgraded blog where I could make a quick visual check to see if the upgrade hadn't broken anything. I imagine this is the expected behavior for most users but I'd appreciate any feedback that makes a case for the current behavior.

Attachments (1)

5438.patch (665 bytes) - added by pishmishy 17 years ago.
Consistent direction

Download all attachments as: .zip

Change History (9)

#1 @pishmishy
17 years ago

  • Owner changed from anonymous to pishmishy
  • Status changed from new to assigned

#2 @Viper007Bond
17 years ago

-1 to changing this.

For normal usage, this redirects you back to the page you were trying to view in your admin area. This is very nice and it'd be a pain if I had to re-navigate to that page after upgrading.

Solution for you: change your list and it's links to this:

http://site.com/wp-admin/upgrade.php?_wp_http_referer=http://site.com/

#3 @Viper007Bond
17 years ago

Er, correction: -1 to removing the referer redirect. +1 to consistency.

#4 follow-up: @pishmishy
17 years ago

I can see the case for either way now. I've never upgraded from within the admin area (the instructions don't lead you this way) but you and others obviously do.

I suspect that neither of us are typical users and that we're not going to get a good sample of typical users on trac. I'll ask on the forums (http://wordpress.org/support/topic/146974) and see if there's a consensus before writing up the rather simple patch - otherwise I'll go with your suggestion.

#5 in reply to: ↑ 4 @Viper007Bond
17 years ago

Replying to pishmishy:

I can see the case for either way now. I've never upgraded from within the admin area (the instructions don't lead you this way) but you and others obviously do.

I usually just go to my /wp-admin/ bookmark which notices my database is out of date and automatically displays a message and a link saying I need to upgrade.

@pishmishy
17 years ago

Consistent direction

#6 @pishmishy
17 years ago

  • Keywords has-patch added

#7 @thee17
17 years ago

  • Milestone changed from 2.6 to 2.5

#8 @pishmishy
17 years ago

  • Milestone 2.6 deleted
  • Resolution set to fixed
  • Status changed from assigned to closed

Behavior has changed in trunk. If the 'backto' parameter has been set then that URL is used, otherwise get_option('home') is used.

Note: See TracTickets for help on using tickets.