Move CSS code that hides visibility and status for wp_navigation type posts from Gutenberg to Core

[antonvlasenko]

The Gutenberg plugin currently contains CSS code that hides visibility and status for wp_navigation type posts. If and when the Gutenberg plugin is merged to Core, we need to move that CSS code from "gutenberg_hide_visibility_and_status_for_navigation_posts" function to the wp-admin/css/edit.css.

[antonvlasenko]

GH issue: ​https://github.com/WordPress/gutenberg/issues/36309
GH PR related to this ticket: ​https://github.com/WordPress/gutenberg/pull/36363

[noisysocks]

The Gutenberg plugin is forced to use CSS to do this but there's no such limitation in Core.

We should fix this by modifying wp-admin/includes/meta-boxes.php. Either by hardcoding a check for wp_navigation, or, ideally, by adding two new hooks which wp-includes/defalt-filters.php uses similarly to _disable_block_editor_for_navigation_post_type.

[hellofromTonya]

Hey @antonvlasenko, what's the status of this ticket? Could it be ready for Beta 1?

[antonvlasenko]

@hellofromTonya I should be able to create a PR in 30-60 minutes or so.
But I'm not sure if we should add new hooks as proposed here.
Most likely, we will disable UI (show_ui option) for wp_navigation posts in the future. These hooks will become unused.
cc @noisysocks

Trac ticket: https://core.trac.wordpress.org/ticket/54407

[antonvlasenko]

Steps to test ​this PR:

1. Activate Twenty Twenty-Two theme.
2. Go to Appearance -> Navigation Menus.
3. Click Add New button.
4. Make sure you can't edit visibility and status settings (they should be hidden).

[costdev]

Test Report

Env

• WordPress 5.9-alpha-51272-src
• Chrome 96.0.4664.45
• WSL2
• Theme: Twenty Twenty Two
• Gutenberg Editor
• Plugin: None activated

Steps to test

1. Activate Twenty Twenty-Two theme.
2. Go to Appearance -> Navigation Menus.
3. Click Add New button.
4. Make sure you can't edit visibility and status settings (they should be hidden).

Results

Before PR 1980: The visibility and status settings are available and can be edited. ❌
After PR 1980: The visibility and status settings are hidden and can't be edited. ✅

Notes

After creating a Navigation Menu and navigating to /edit.php?post_type=wp_navigation, it is possible to edit the Status by clicking Quick Edit.

Pinging @antonvlasenko for an update as this was to be raised as an issue in the GB repo and would be worthwhile to have as part of this PR.

[costdev]

Before and After PR 1980

[antonvlasenko]

As we (@costdev and I) agreed, I've committed @costdev's ​fix.
So https://core.trac.wordpress.org/ticket/54407#comment:9 should be fixed now.

[costdev]

Test Report 2

Env

• WordPress 5.9-alpha-51272-src
• Chrome 96.0.4664.45
• WSL2
• Theme: Twenty Twenty Two
• Gutenberg Editor
• Plugin: None activated

Steps to test

1. Activate Twenty Twenty-Two theme.
2. Go to Appearance -> Navigation Menus.
3. Add a new Navigation Menu.
4. Navigate to Appearance -> Navigation Menus.
5. Click Quick Edit.
6. Make sure you can't edit the Status setting.

Results

Before PR 1980: The Status setting is available and can be edited. ❌
After PR 1980: The Status setting is hidden and can't be edited. ✅

[costdev]

Before and After PR 1980 (2)

[hellofromTonya]

Marking ​PR 1980 ready for commit.

[hellofromTonya]

In 52293:

Editor: Hide visibility and status settings for wp_navigation post type.

Adds CSS to hide both the visibility and status settings for the wp_navigation post type.

Props antonvlasenko , costdev.
Fixes #54407.

Committed via https://core.trac.wordpress.org/changeset/52293.

[noisysocks]

Most likely, we will disable UI (show_ui option) for wp_navigation posts in the future.

Yes I think we should do this. There's a ticket here: ​https://github.com/WordPress/gutenberg/issues/36589