WordPress.org

Make WordPress Core

Opened 4 weeks ago

Closed 3 weeks ago

#54408 closed defect (bug) (fixed)

Twenty Eleven: comment form styling

Reported by: sabernhardt Owned by: SergeyBiryukov
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch has-screenshots commit
Focuses: css Cc:

Description

With absolute positioning, the star character to signify required comment form fields can overlap the text in some languages.

Also, the star's styling is inconsistent between the input labels and the comment notes paragraph (including the Comments label and logged_in_as message after r52029).

Attachments (3)

54408.diff (1.5 KB) - added by sabernhardt 4 weeks ago.
2011-comments-form-before.png (542.5 KB) - added by sabernhardt 4 weeks ago.
before applying patch
2011-comments-form-after.png (560.5 KB) - added by sabernhardt 4 weeks ago.
with patch

Download all attachments as: .zip

Change History (6)

@sabernhardt
4 weeks ago

@sabernhardt
4 weeks ago

before applying patch

@sabernhardt
4 weeks ago

with patch

#1 @sabernhardt
4 weeks ago

  • Keywords has-patch has-screenshots added

#2 @hellofromTonya
3 weeks ago

  • Keywords commit added

I can confirm the patch resolves the issue. Marking for commit.

#3 @SergeyBiryukov
3 weeks ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 52152:

Twenty Eleven: Improve comment form styling for required fields.

Previously, with absolute positioning, the star character to signify required comment form fields could overlap the text in some languages. The star's styling was also inconsistent between the input labels and the comment notes paragraph.

This commit makes the star's styling more consistent and ensures it does not overlap with the text.

Follow-up to [52029].

Props sabernhardt, hellofromTonya.
Fixes #54408.

Note: See TracTickets for help on using tickets.