WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#54408 closed defect (bug) (fixed)

Twenty Eleven: comment form styling

Reported by: sabernhardt Owned by: SergeyBiryukov
Priority: normal Milestone: 5.9
Component: Bundled Theme Version:
Severity: normal Keywords: has-patch has-screenshots has-dev-note
Cc: Focuses: css

Description

With absolute positioning, the star character to signify required comment form fields can overlap the text in some languages.

Also, the star's styling is inconsistent between the input labels and the comment notes paragraph (including the Comments label and logged_in_as message after r52029).

Attachments (3)

54408.diff​ (1.5 KB ) - added by sabernhardt 5 years ago.
2011-comments-form-before.png​ (542.5 KB ) - added by sabernhardt 5 years ago.
before applying patch
2011-comments-form-after.png​ (560.5 KB ) - added by sabernhardt 5 years ago.
with patch

Download all attachments as: .zip

Change History (7)

@sabernhardt
5 years ago

@sabernhardt
5 years ago

before applying patch

@sabernhardt
5 years ago

with patch

#1 @sabernhardt
5 years ago

  • Keywords has-patch has-screenshots added

#2 @hellofromTonya
5 years ago

  • Keywords commit added

I can confirm the patch resolves the issue. Marking for commit.

#3 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 52152:

Twenty Eleven: Improve comment form styling for required fields.

Previously, with absolute positioning, the star character to signify required comment form fields could overlap the text in some languages. The star's styling was also inconsistent between the input labels and the comment notes paragraph.

This commit makes the star's styling more consistent and ensures it does not overlap with the text.

Follow-up to [52029].

Props sabernhardt, hellofromTonya.
Fixes #54408.

#4 @sabernhardt
5 years ago

  • Keywords has-dev-note added; commit removed

Bundled themes update note:
​https://make.wordpress.org/core/2022/01/05/bundled-theme-updates-with-wordpress-5-9/

Note: See TracTickets for help on using tickets.