Changes between Initial Version and Version 1 of Ticket #54410, comment 8
- Timestamp:
- 11/17/2021 12:44:32 PM (3 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #54410, comment 8
initial v1 1 1 @desrosj That's excellent news about the performance improvements! 2 2 3 However, in terms of this ticket, performance wasn't the primary benefit of the suggested change. The primary benefit is that coding standards, or other coding failures, will no longer cause CI failures across the board because commits to core aren't fully checked before submitting. 3 However, in terms of this ticket, performance wasn't the primary benefit of the suggested change. The primary benefit is that coding standards, or other coding failures, will no longer cause CI failures across the board because commits to core aren't fully checked before submitting. The remaining benefits are in the initial ticket description. 4 4 5 5 I agree that the information in the handbook surrounding commits should be followed, but one of the reasons that we have automated checks for tests and standards on PRs is because we accept that mistakes happen and we need to verify that everything is as it should be. However, commits to core don't have the same pre-merge enforcement of automated checks, otherwise they'd never make it into core.