Exclude plugins and themes from PHP Compatibility scans

[desrosj]

Currently, the wp-content/plugins, wp-content/themes, and wp-content/mu-plugins directories are not excluded in the PHP compatibility check ruleset in trunk.

These are excluded for PHPCS scans, and should also be excluded for compatibility scans.

[desrosj]

In 52148:

Build/Test Tools: Exclude plugins and non-bundled themes from PHP compatibility scans.

Fixes #54425.

[jrf]

Eh.. @desrosj This was originally set up like that by design as, while those files do not have to comply with the WP coding standards, we do want to make sure they are PHP cross-version compatible and won't crash sites.

The PHPCompatibility scan has a different remit than the WPCS scan, so IMO, this commit should be reverted.

[ocean90]

I think the only file which is now not checked anymore is wp-content/plugins/hello.php. Everything else that's bundled with WordPress is still checked.

[desrosj]

I came across this when I had several plugins from WordPress.org installed and the scan was displaying a lot of errors. The plugins are not a part of Core, so I figured the Core ruleset could exclude them.

Plugins don't need to support the same PHP versions as WordPress since they can define their own lower limit (WooCommerce only supports PHP 7.0+, for example), so this could result in some very noisy scan results when trying to verify WordPress Core is compatible with the current ruleset.

Happy to revert if there's consensus, but as far as I know, the thinking has always been to only run scans on files included in the final WordPress package.

…CS workflows.

This ensures that the cache is reset when changes are made to the rulesets and not the composer.json file.

Trac ticket:

[desrosj]

In 52220:

Build/Test Tools: Add the ruleset file to the cache key for PHPCS and PHP compatibility scans.

This ensures that the cache is busted properly when the ruleset is adjusted but the composer.json file is not.

See #54425.

Merged in https://core.trac.wordpress.org/changeset/52220.

[hellofromTonya]

Reclassifying to task to let it stay in the beta cycle. Will review after Beta 1 ships.

[hellofromTonya]

Haven't had time to review this ticket. Moving it to 6.0 as likely won't have time with the focus on 5.9.

[ocean90]

Re-closing as fixed since the commits are already in trunk.