WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#54429 closed defect (bug) (fixed)

Skip link focus fix is output twice in Twenty Twenty-One if SCRIPT_DEBUG is enabled

Reported by: westonruter's profile westonruter Owned by: westonruter's profile westonruter
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.6
Component: Bundled Theme Keywords: has-patch
Focuses: javascript Cc:

Description

There is a missing else statement in twenty_twenty_one_skip_link_focus_fix().

Change History (4)

#1 @westonruter
3 years ago

  • Owner set to westonruter
  • Status changed from new to accepted

This ticket was mentioned in ​PR #1875 on ​WordPress/wordpress-develop by ​westonruter.
3 years ago #2

  • Keywords has-patch added

Trac ticket: [](https://core.trac.wordpress.org/ticket/54429)

#3 @westonruter
3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 52147:

Twenty Twenty-One: Prevent printing skip link focus fix when SCRIPT_DEBUG is enabled.

An else statement was missing in twenty_twenty_one_skip_link_focus_fix(). See ​https://github.com/WordPress/twentytwentyone/pull/585/commits/ba83586ff1426fc4a0248f45d27ad0b4f5b7bbd4.

Fixes #54429.

​westonruter commented on ​PR #1875:
3 years ago #4

Committed to trunk in r52147.

Note: See TracTickets for help on using tickets.