Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#54429 closed defect (bug) (fixed)

Skip link focus fix is output twice in Twenty Twenty-One if SCRIPT_DEBUG is enabled

Reported by: westonruter Owned by: westonruter
Priority: normal Milestone: 5.9
Component: Bundled Theme Version: 5.6
Severity: normal Keywords: has-patch
Cc: Focuses: javascript

Description

There is a missing else statement in twenty_twenty_one_skip_link_focus_fix().

Change History (4)

#1 @westonruter
5 years ago

  • Owner set to westonruter
  • Status new → accepted

This ticket was mentioned in ​PR #1875 on ​WordPress/wordpress-develop by ​westonruter.


5 years ago
#2

  • Keywords has-patch added

#3 @westonruter
5 years ago

  • Resolution → fixed
  • Status accepted → closed

In 52147:

Twenty Twenty-One: Prevent printing skip link focus fix when SCRIPT_DEBUG is enabled.

An else statement was missing in twenty_twenty_one_skip_link_focus_fix(). See ​https://github.com/WordPress/twentytwentyone/pull/585/commits/ba83586ff1426fc4a0248f45d27ad0b4f5b7bbd4.

Fixes #54429.

​westonruter commented on ​PR #1875:


5 years ago
#4

Committed to trunk in r52147.

Note: See TracTickets for help on using tickets.