Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#54441 closed defect (bug) (fixed)

Toolbar: refine 'Edit site' link

Reported by: sabernhardt's profile sabernhardt Owned by: davidbaumwald's profile davidbaumwald
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.9
Component: Toolbar Keywords: has-patch
Focuses: css Cc:

Description

The 'Edit site' link was added to core in r52158, without an icon and hidden on narrower screens.

If it should show on mobile, which icon would make sense? The same paintbrush used for Customize?

Attachments (5)

toolbar-edit-site.png (4.3 KB) - added by sabernhardt 2 years ago.
54441-customize.diff (1.4 KB) - added by sabernhardt 2 years ago.
with Customize paintbrush icon
54441-appearance.diff (1.5 KB) - added by sabernhardt 2 years ago.
with Appearance paintbrush icon
toolbar-edit-site-customize-icon.png (50.6 KB) - added by sabernhardt 2 years ago.
toolbar-edit-site-appearance-icon.png (51.2 KB) - added by sabernhardt 2 years ago.

Download all attachments as: .zip

Change History (14)

#1 @sabernhardt
2 years ago

  • Version set to trunk

This ticket was mentioned in Slack in #core by sabernhardt. View the logs.


2 years ago

#3 @desrosj
2 years ago

I do tend to lean towards the same icon as Customize. But there are pros and cons. Someone that is accustomed to using the Customizer will be more likely to click that and find the new place to edit the site's appearance. But that could also be bad because it's nowhere near the same experience, so a new icon may be better there so the user associates it with a "new experience".

@sabernhardt
2 years ago

with Customize paintbrush icon

@sabernhardt
2 years ago

with Appearance paintbrush icon

#4 @sabernhardt
2 years ago

  • Focuses css added
  • Keywords has-patch needs-design-feedback added; needs-design removed

Consistency is good, so I made a version with the Customize icon.

The Appearance icon could work, too. It's familiar enough for anyone who has seen it in the admin menu, in a similar context. Plus, it still depicts a paintbrush (except here we would use the 'two-inch brush' to represent this feature).

Last edited 2 years ago by sabernhardt (previous) (diff)

This ticket was mentioned in Slack in #design by sabernhardt. View the logs.


2 years ago

#6 @shaunandrews
2 years ago

  • Keywords needs-design-feedback removed

The Appearance icon could work, too. It's familiar enough for anyone who has seen it in the admin menu, in a similar context. Plus, it still depicts a paintbrush (except here we would use the 'two-inch brush' to represent this feature).

This was brought up in today's Design Team meeting. The consensus was that the "Appearance" brush icon was a better option. Nice work, @sabernhardt!

This ticket was mentioned in Slack in #core by sabernhardt. View the logs.


2 years ago

#8 @davidbaumwald
2 years ago

  • Owner set to davidbaumwald
  • Status changed from new to accepted

#9 @davidbaumwald
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 52209:

Toolbar: Refine "Edit site" link.php.

The 'Edit site' link was added to core in [52158], but did not include an icon and was hidden for smaller screen sizes. This change adds the "Appearance" icon to the link and hides the link text when necessary on smaller screen sizes.

Props sabernhardt, desrosj, shaunandrews.
Fixes #54441.

Note: See TracTickets for help on using tickets.