WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#54444 closed defect (bug) (reported-upstream)

Incorrect textdomain in Calendar block

Reported by: kebbet's profile kebbet Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.9
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

Introduced in src/wp-includes/blocks/calendar.php, on line 22 in ticket https://core.trac.wordpress.org/ticket/54337

See open PR on GitHub -> ​https://github.com/WordPress/wordpress-develop/pull/1845

Change History (6)

This ticket was mentioned in ​PR #1845 on ​WordPress/wordpress-develop by ​kebbet.
3 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/54444

Remove the incorrect use of text domain from core.

#2 @swissspidy
3 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 5.9

#3 @desrosj
3 years ago

  • Keywords close added; commit removed

It looks like running grunt build reverts this change.

I believe this is because the PHP file is being copied over from the @wordpress package when WordPress is built. This should be ​fixed in the package upstream, and then this will be fixed with a new version of the block library package.

#5 @audrasjb
3 years ago

  • Keywords close removed
  • Milestone 5.9 deleted
  • Resolution set to reported-upstream
  • Status changed from new to closed

This was fixed upstream: ​https://github.com/WordPress/gutenberg/pull/36500

Thanks for spotting this and reporting the issue!

​SergeyBiryukov commented on ​PR #1845:
3 years ago #6

Thanks for the PR! Closing as this was fixed upstream in ​https://github.com/WordPress/gutenberg/pull/36500.

Note: See TracTickets for help on using tickets.