Opened 3 years ago
Closed 3 years ago
#54446 closed defect (bug) (reported-upstream)
Remove reference to Gutenberg from option name
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | 5.9 | Priority: | normal |
| Severity: | normal | Version: | 5.9 |
| Component: | Editor | Keywords: | has-patch |
| Focuses: | Cc: |
Description
In https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/blocks/calendar.php on line 103 (in the function block_core_calendar_update_has_published_posts) the option is named gutenberg_calendar_block_has_published_posts. Should it be called something else? The option is retrieved in the function block_core_calendar_has_published_posts some lines above, and may be updated as well.
Change History (6)
This ticket was mentioned in PR #1888 on WordPress/wordpress-develop by kebbet.
3 years ago
#1
- Keywords has-patch added; needs-patch removed
#2
@
3 years ago
- Component changed from General to Editor
- Milestone changed from Awaiting Review to 5.9
#3
@
3 years ago
Hi there, thanks for the ticket and the PR!
Introduced in [52042] / #54337.
Just noting that this needs to be fixed in the package upstream and then backported to core, same as #54444.
3 years ago
#5
Handled upstream at https://github.com/WordPress/gutenberg/pull/36652
#6
@
3 years ago
- Resolution set to reported-upstream
- Status changed from new to closed
This was fixed upstream: https://github.com/WordPress/gutenberg/pull/36652#event-5660387654
Trac ticket: https://core.trac.wordpress.org/ticket/54446
Rename
gutenberg_calendar_block_has_published_poststowp_calendar_block_has_published_posts