WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#5446 closed defect (bug) (fixed)

Return error when requesting invalid feed format

Reported by: pishmishy Owned by: pishmishy
Milestone: 2.5 Priority: normal
Severity: normal Version: 2.3.1
Component: General Keywords: has-patch feeds
Focuses: Cc:

Description

Requesting an invalid feed format (say http://www.myblog.com/?feed=foo) results in a blank page. This is due to do_feed() in functions.php calling hooked actions without any feedback on whether the appropriate action actually exists. Depends on #5445.

Attachments (1)

5446.patch (513 bytes) - added by pishmishy 6 years ago.
New patch, translatable and escaped text

Download all attachments as: .zip

Change History (6)

comment:1 pishmishy6 years ago

  • Status changed from new to assigned

comment:2 pishmishy6 years ago

Revised patch using feedback from #5445

comment:3 ryan6 years ago

$feed needs to be escaped to avoid XSS. The message also need to be marked for translation.

pishmishy6 years ago

New patch, translatable and escaped text

comment:4 ryan6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [7038]) Return error when requesting invalid feed format. Props pishmishy. fixes #5446

comment:5 ryan6 years ago

  • Milestone changed from 2.6 to 2.5
Note: See TracTickets for help on using tickets.