WordPress.org

Make WordPress Core

Opened 12 days ago

Last modified 7 hours ago

#54460 assigned defect (bug)

Ensure links to the Customizer send users to an appropriate destination in 5.9

Reported by: jameskoster Owned by: antonvlasenko
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch commit
Focuses: ui, administration Cc:

Description

In 5.9, when a block theme is active, access to the Customizer is hidden by default. There are however a few remaining links to the Customizer throughout the wp-admin interface. In particular on the Themes page, and on the Dashboard.

It might be better to make the destination of these links conditional. IE if a classic theme is active, link to the Customizer (no change). If a block theme is active link to Appearance > Editor.

Attachments (3)

142033022-ed9dd2be-4a30-44ae-a7fa-c04099b65ac1.png (129.2 KB) - added by jameskoster 12 days ago.
114105726-876e6580-988a-11eb-9450-af8f15705c08.png (351.6 KB) - added by jameskoster 12 days ago.
Screenshot 2021-11-22 at 11.27.10.png (35.1 KB) - added by jameskoster 7 days ago.
Customize link in the Theme Editor

Download all attachments as: .zip

Change History (18)

#1 @SergeyBiryukov
12 days ago

  • Component changed from General to Customize
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.9

Hi there, welcome back to WordPress Trac!

Thanks for the report, moving to the milestone for visibility.

#2 @SergeyBiryukov
12 days ago

  • Focuses ui administration added

#3 @poena
12 days ago

Before this can be done, the solutions for the site icon and starter content needs to be completed:

Last edited 11 days ago by SergeyBiryukov (previous) (diff)

#4 @matveb
12 days ago

Regarding the "welcome to WordPress" box, it goes beyond just updating the links. This is a missed opportunity to establish the main concepts (blocks, patterns, styles), set the right expectations (early access?), and guide users better.

#5 @noisysocks
11 days ago

Closed https://github.com/WordPress/gutenberg/issues/36578 in favour of this ticket. See there for some more commentary.

#6 @noisysocks
11 days ago

  • Component changed from Customize to General
  • Keywords needs-design added

#7 @poena
11 days ago

Regarding the "welcome to WordPress" box, it goes beyond just updating the links. This is a missed opportunity to establish the main concepts (blocks, patterns, styles), set the right expectations (early access?), and guide users better.

I love that idea.
Does it needs it's own issue though?

This ticket was mentioned in Slack in #core-editor by noisysocks. View the logs.


10 days ago

@jameskoster
7 days ago

Customize link in the Theme Editor

#9 @desrosj
7 days ago

Related: #54489.

#10 @antonvlasenko
6 days ago

I'm working on this issue.

This ticket was mentioned in Slack in #core-editor by noisysocks. View the logs.


6 days ago

This ticket was mentioned in PR #1933 on WordPress/wordpress-develop by anton-vlasenko.


6 days ago

  • Keywords has-patch added; needs-patch removed

In 5.9, when a block theme is active, access to the Customizer is hidden by default. There are however a few remaining links to the Customizer throughout the wp-admin interface. In particular on the Themes page, and on the Dashboard.

This PRs aims to change these links depending on the current theme. If the current theme is block-based, we send users to the Appearance -> Editor page instead.

Trac ticket: https://core.trac.wordpress.org/ticket/54460

#13 @noisysocks
5 days ago

  • Owner set to antonvlasenko
  • Status changed from new to assigned

#14 @prbot
3 days ago

anton-vlasenko commented on PR #1933:

I've added 2 new test block themes. I tried to modify the old ones and this caused unit tests to fail. They are not intended to be the block themes (despite their names).

#15 @noisysocks
7 hours ago

  • Keywords commit added; needs-design removed

Thanks @antonvlasenko. Let's get this in for beta 1 and make any necessary tweaks as follow-up commits.

Note: See TracTickets for help on using tickets.